mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: tony@atomide.com, daniel.lezcano@linaro.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	aford173@gmail.com, drivshin@awxrd.com
Subject: [RFC PATCH 4/4] timer-ti-dm: Fix omap_dm_timer_of_set_source()
Date: Mon, 16 Jul 2018 22:39:02 +0200	[thread overview]
Message-ID: <1531773542-15736-5-git-send-email-narmstrong@baylibre.com> (raw)
In-Reply-To: <1531773542-15736-1-git-send-email-narmstrong@baylibre.com>

With the move to clocksource, the omap_dm_timer_of_set_source() broke
because the "fclk" clock is now defined in the DT.
The omap_dm_timer_of_set_source() was using the first clock declared in the
timer node, but now this clock must be named as "src" and clk_get() use
"src" as clock name to permit specifiying the parent clock of the timer "fclk".

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/clocksource/timer-ti-dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index 4cce6b2..868bc78 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -150,7 +150,7 @@ static int omap_dm_timer_of_set_source(struct omap_dm_timer *timer)
 	if (!timer->fclk)
 		return -ENODEV;
 
-	parent = clk_get(&timer->pdev->dev, NULL);
+	parent = clk_get(&timer->pdev->dev, "src");
 	if (IS_ERR(parent))
 		return -ENODEV;
 
-- 
2.7.4


  parent reply	other threads:[~2018-07-16 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 20:38 [RFC PATCH 0/4] Fix dmtimer parent clock setup Neil Armstrong
2018-07-16 20:38 ` [RFC PATCH 1/4] ARM: dts: am33xx: Add all fck timer clocks Neil Armstrong
2018-07-17  5:55   ` Tony Lindgren
2018-07-17 20:28     ` Neil Armstrong
2018-07-19  6:42       ` Tony Lindgren
2018-07-16 20:39 ` [RFC PATCH 2/4] ARM: dts: am4372: " Neil Armstrong
2018-07-16 20:39 ` [RFC PATCH 3/4] ARM: dts: dm816x: " Neil Armstrong
2018-07-16 20:39 ` Neil Armstrong [this message]
2018-07-16 23:21 ` [RFC PATCH 0/4] Fix dmtimer parent clock setup David Rivshin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531773542-15736-5-git-send-email-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=aford173@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=drivshin@awxrd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®