mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Rivshin <drivshin@awxrd.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: tony@atomide.com, daniel.lezcano@linaro.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	aford173@gmail.com
Subject: Re: [RFC PATCH 0/4] Fix dmtimer parent clock setup
Date: Mon, 16 Jul 2018 19:21:41 -0400	[thread overview]
Message-ID: <20180716192141.28269517.drivshin@awxrd.com> (raw)
In-Reply-To: <1531773542-15736-1-git-send-email-narmstrong@baylibre.com>

On Mon, 16 Jul 2018 22:38:58 +0200
Neil Armstrong <narmstrong@baylibre.com> wrote:

> With the move to clocksource, the omap_dm_timer_of_set_source() broke
> because the "fclk" clock is now defined in the DT.
> The omap_dm_timer_of_set_source() was using the first clock declared in the
> timer node, but now this clock must be named as "src" and clk_get() use
> "src" as clock name to permit specifiying the parent clock of the timer "fclk".
> 
> The 3 first patches adds the "fck" clocks to all timer nodes of SoCs using
> the Clock Framework to pass this clock to the dmtimer driver.
> 
> Adam, David, can you check if this solves the issue reported at [1] ?

Thanks! Works on my AM335x board.
Patches 1 and 4:
 Tested-by: David Rivshin <drivshin@allworx.com>

If I might suggest also:
 Fixes: df54bfc5502a ("clk: ti: am33xx: add clkctrl clock data")
 Cc: <stable@vger.kernel.org> # 4.16+


> 
> [1] https://www.spinics.net/lists/linux-clk/msg27638.html
> 
> Neil Armstrong (4):
>   ARM: dts: am33xx: Add all fck timer clocks
>   ARM: dts: am4372: Add all fck timer clocks
>   ARM: dts: dm816x: Add all fck timer clocks
>   timer-ti-dm: Fix omap_dm_timer_of_set_source()
> 
>  arch/arm/boot/dts/am33xx.dtsi     | 10 ++++++++++
>  arch/arm/boot/dts/am4372.dtsi     | 18 ++++++++++++++++++
>  arch/arm/boot/dts/dm816x.dtsi     | 10 ++++++++++
>  drivers/clocksource/timer-ti-dm.c |  2 +-
>  4 files changed, 39 insertions(+), 1 deletion(-)
> 


      parent reply	other threads:[~2018-07-16 23:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 20:38 Neil Armstrong
2018-07-16 20:38 ` [RFC PATCH 1/4] ARM: dts: am33xx: Add all fck timer clocks Neil Armstrong
2018-07-17  5:55   ` Tony Lindgren
2018-07-17 20:28     ` Neil Armstrong
2018-07-19  6:42       ` Tony Lindgren
2018-07-16 20:39 ` [RFC PATCH 2/4] ARM: dts: am4372: " Neil Armstrong
2018-07-16 20:39 ` [RFC PATCH 3/4] ARM: dts: dm816x: " Neil Armstrong
2018-07-16 20:39 ` [RFC PATCH 4/4] timer-ti-dm: Fix omap_dm_timer_of_set_source() Neil Armstrong
2018-07-16 23:21 ` David Rivshin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716192141.28269517.drivshin@awxrd.com \
    --to=drivshin@awxrd.com \
    --cc=aford173@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®