* [PATCH -next] staging: axis-fifo: fix return value check in axis_fifo_probe()
@ 2018-07-27 7:15 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2018-07-27 7:15 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jacob Feder
Cc: Wei Yongjun, devel, linux-kernel, kernel-janitors
In case of error, the function device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 2a73302..51a081d 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -1006,10 +1006,10 @@ static int axis_fifo_probe(struct platform_device *pdev)
/* create driver file */
fifo->device = device_create(axis_fifo_driver_class, NULL, fifo->devt,
NULL, device_name);
- if (!fifo->device) {
+ if (IS_ERR(fifo->device)) {
dev_err(fifo->dt_device,
"couldn't create driver file\n");
- rc = -ENOMEM;
+ rc = PTR_ERR(fifo->device);
goto err_chrdev_region;
}
dev_set_drvdata(fifo->device, fifo);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-27 7:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 7:15 [PATCH -next] staging: axis-fifo: fix return value check in axis_fifo_probe() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®