From: "Stephan Müller" <smueller@chronox.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
Date: Sun, 26 Mar 2017 19:05:48 +0200 [thread overview]
Message-ID: <1535446.zHpTqe8jba@positron.chronox.de> (raw)
In-Reply-To: <CANc+2y4xkDs2kQGXKP=8i_v9oYw4dPKTjWs0xFnvOcwDbar47g@mail.gmail.com>
Am Sonntag, 26. März 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:
Hi Krzysztof,
> >> > + if (slen < EXYNOS_RNG_SEED_SIZE) {
> >> > + dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
> >> > slen); + return -EINVAL;
> >> > + }
> >>
> >> Will it be helpful to print the required seed size?
> >
> > It is in /proc/crypto... It is not a problem to print it but isn't that
> > redundant?
>
> Not necessary if it is already available.
Maybe the dev_warn should be removed. Note, unprivileged user space can
trigger this warning by simply invoking the seeding operation over and over
again with an insufficient seed size. This would clutter the log.
Ciao
Stephan
next prev parent reply other threads:[~2017-03-26 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 16:26 [PATCH v3 0/3] " Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 1/3] " Krzysztof Kozlowski
2017-03-26 15:20 ` PrasannaKumar Muralidharan
2017-03-26 16:01 ` Krzysztof Kozlowski
2017-03-26 16:05 ` Stephan Müller
2017-03-26 16:46 ` PrasannaKumar Muralidharan
2017-03-26 17:05 ` Stephan Müller [this message]
2017-03-26 18:09 ` Krzysztof Kozlowski
2017-03-26 17:11 ` Stephan Müller
2017-03-26 18:00 ` Krzysztof Kozlowski
2017-03-26 21:25 ` Stephan Müller
2017-03-27 4:23 ` PrasannaKumar Muralidharan
2017-03-27 13:53 ` Stephan Müller
2017-03-28 16:48 ` Krzysztof Kozlowski
2017-03-28 17:41 ` Stephan Müller
2017-03-28 17:43 ` Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 2/3] ARM: exynos_defconfig: Enable Exynos RNG and user-space crypto API Krzysztof Kozlowski
2017-03-25 16:26 ` [PATCH v3 3/3] ARM: multi_v7_defconfig: " Krzysztof Kozlowski
2017-03-25 16:32 ` [PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535446.zHpTqe8jba@positron.chronox.de \
--to=smueller@chronox.de \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
--cc=prasannatsmkumar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®