* [PATCH] kconfig: remove a spurious self-assignment
@ 2018-08-30 9:18 Lukas Bulwahn
2018-08-31 14:45 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2018-08-30 9:18 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Sam Ravnborg, linux-kbuild, linux-kernel, Lukas Bulwahn
The self assignment was probably introduced by an automated code
refactoring in
commit 694c49a7c01c ("kconfig: drop localization support").
The issue was identified by a self-assign warning when running
make menuconfig with clang.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
scripts/kconfig/mconf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 83b5836..143c05f 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -490,7 +490,6 @@ static void build_conf(struct menu *menu)
switch (prop->type) {
case P_MENU:
child_count++;
- prompt = prompt;
if (single_menu_mode) {
item_make("%s%*c%s",
menu->data ? "-->" : "++>",
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] kconfig: remove a spurious self-assignment
2018-08-30 9:18 [PATCH] kconfig: remove a spurious self-assignment Lukas Bulwahn
@ 2018-08-31 14:45 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2018-08-31 14:45 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Sam Ravnborg, Linux Kbuild mailing list, Linux Kernel Mailing List
2018-08-30 18:18 GMT+09:00 Lukas Bulwahn <lukas.bulwahn@gmail.com>:
> The self assignment was probably introduced by an automated code
> refactoring in
> commit 694c49a7c01c ("kconfig: drop localization support").
>
> The issue was identified by a self-assign warning when running
> make menuconfig with clang.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
Applied to linux-kbuild/fixes. Thanks!
> scripts/kconfig/mconf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 83b5836..143c05f 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -490,7 +490,6 @@ static void build_conf(struct menu *menu)
> switch (prop->type) {
> case P_MENU:
> child_count++;
> - prompt = prompt;
> if (single_menu_mode) {
> item_make("%s%*c%s",
> menu->data ? "-->" : "++>",
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-31 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 9:18 [PATCH] kconfig: remove a spurious self-assignment Lukas Bulwahn
2018-08-31 14:45 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®