From: "Nanzhe Zhao" <nzzhao@126.com>
To: "Jaegeuk Kim" <jaegeuk@kernel.org>
Cc: "Nanzhe Zhao" <nzzhao.sigma@gmail.com>,
"Barry Song" <baohua@kernel.org>,
"Nanzhe Zhao" <zhaonanzhe@xiaomi.com>,
"Juan Yescas" <jyescas@google.com>,
"Daeho Jeong" <daehojeong@google.com>,
"Dev Jain" <Dev.Jain@arm.com>,
linux-kernel@vger.kernel.org,
"David Hildenbrand" <David.Hildenbrand@arm.com>,
"Pengfei Li" <lipengfei28@xiaomi.com>,
"Bo Zhang" <zhangbo56@xiaomi.com>,
"Kalesh Singh" <kaleshsingh@google.com>,
"Ryan Roberts" <Ryan.Roberts@arm.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re:Re: [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files
Date: Sat, 17 Oct 2026 18:00:47 +0800 (CST) [thread overview]
Message-ID: <15373a26.1e3d.1a1494e8d1a.Coremail.nzzhao@126.com> (raw)
In-Reply-To: <atFFXafuVyyimmUk@google.com>
Hi Jaeguk,
I am trying to reproduce the failure in your log: sd 0:0:0:4: Retrying unaligned write for zone 2639 → critical target error → sde:
zone 2639: Aborting plugged BIOs → f2fs_stop_checkpoint (kernel 6.12.81-android16-6) and got two two questions.
1. Kernel baseline. Could you confirm that the kernel you tested has Bart Van Assche's zoned write pipelining, i.e. multiple in-flight
sequential writes per zone, with the order kept by BLK_FEAT_ORDERED_HWQ and the per-zone from_cpu in block/blk-zoned.c? And that it
does not include these three follow-up fixes:
- "ANDROID: block: Preserve the submission order of zoned writes"
- "ANDROID: block: Preserve the order of zoned REQ_FUA writes"
- "ANDROID: block: Restore the write pointer offset check"
In AOSP they are 050de570f, c616f7c1a, d50601d0f on android16-6.12, and 6068ed9f0, d786f8609, f08430f80 on android17-6.18. The
simplest check is whether REQ_ZONE_SERIALIZED and work_busy(&zwplug->bio_work) appear in your block/blk-zoned.c. The output of git log
--oneline -- block/blk-zoned.c would also do.
2. Test workload. If that is the case, could you share the test workload that triggers it? So far I have not been able to reproduce it using null_blk to simulate
zone devices with qemu and android17-6.18 gki kernel. Any suggestions would be much appreciated.
Thanks,
next prev parent reply other threads:[~2026-10-17 10:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:44 Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 01/16] f2fs: extend folio state for large folio write path Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 02/16] f2fs: carry subpage offset and count in write IO Nanzhe Zhao
2026-10-15 2:37 ` [f2fs-dev] " Jaegeuk Kim
2026-10-14 6:44 ` [PATCH v5 03/16] f2fs: support regular file buffered writes on large folios Nanzhe Zhao
2026-10-15 13:11 ` Chao Yu
2026-10-16 0:04 ` Chao Yu
2026-10-16 5:52 ` Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 04/16] f2fs: support atomic file large folios buffered write Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 05/16] f2fs: support large folio writeback Nanzhe Zhao
2026-10-16 0:39 ` Chao Yu
2026-10-16 3:57 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 06/16] f2fs: account large folio dirty data at block granularity Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 07/16] f2fs: prepare mmap write faults for large folios Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 08/16] f2fs: make GC migration large-folio aware Nanzhe Zhao
2026-10-16 11:25 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 09/16] f2fs: optimize small block size large folio read Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 10/16] f2fs: support partial uptodate " Nanzhe Zhao
2026-10-15 13:34 ` Chao Yu
2026-10-14 6:44 ` [PATCH v5 11/16] f2fs: handle partial truncate of large folio dirty subpages Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 12/16] f2fs: wait for folio writeback before ffs_detach_free Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 13/16] f2fs: fix zeroing paths for large folios Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 14/16] f2fs: handle block cloning within the same large folio Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 15/16] f2fs: allow large folio support to writeable files Nanzhe Zhao
2026-10-14 6:44 ` [PATCH v5 16/16] f2fs: make compressed files compatible with large folio Nanzhe Zhao
2026-10-14 23:23 ` [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files Jaegeuk Kim
2026-10-15 2:13 ` Jaegeuk Kim
2026-10-15 2:36 ` Chao Yu
2026-10-15 3:33 ` Nanzhe Zhao
2026-10-15 16:19 ` Jaegeuk Kim
2026-10-15 21:27 ` Jaegeuk Kim
2026-10-17 10:00 ` Nanzhe Zhao [this message]
2026-10-15 8:40 ` Nanzhe Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15373a26.1e3d.1a1494e8d1a.Coremail.nzzhao@126.com \
--to=nzzhao@126.com \
--cc=David.Hildenbrand@arm.com \
--cc=Dev.Jain@arm.com \
--cc=Ryan.Roberts@arm.com \
--cc=baohua@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=jyescas@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lipengfei28@xiaomi.com \
--cc=nzzhao.sigma@gmail.com \
--cc=zhangbo56@xiaomi.com \
--cc=zhaonanzhe@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®