* [PATCH] ACPI / SBS: Fix check in acpi_ac_get_present()
@ 2014-09-27 23:28 Rafael J. Wysocki
0 siblings, 0 replies; only message in thread
From: Rafael J. Wysocki @ 2014-09-27 23:28 UTC (permalink / raw)
To: ACPI Devel Maling List
Cc: Linux Kernel Mailing List, Matthew Garrett, Andreas Noever
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Parentheses are missing under an if () statement in
acpi_ac_get_present() which makes the check work differently
from what was intended (at least according to the comment right
above it). Add the missing parens.
The problem was found by sparse.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/sbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pm/drivers/acpi/sbs.c
===================================================================
--- linux-pm.orig/drivers/acpi/sbs.c
+++ linux-pm/drivers/acpi/sbs.c
@@ -441,7 +441,7 @@ static int acpi_ac_get_present(struct ac
* The spec requires that bit 4 always be 1. If it's not set, assume
* that the implementation doesn't support an SBS charger
*/
- if (!(status >> 4) & 0x1)
+ if (!((status >> 4) & 0x1))
return -ENODEV;
sbs->charger_present = (status >> 15) & 0x1;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-27 23:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-27 23:28 [PATCH] ACPI / SBS: Fix check in acpi_ac_get_present() Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®