mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus
@ 2018-12-04  8:54 Anson Huang
  2018-12-04 10:19 ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Anson Huang @ 2018-12-04  8:54 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, Fabio Estevam, robh+dt, mark.rutland,
	linux-arm-kernel, devicetree, linux-kernel
  Cc: dl-linux-imx

Add egalax touch screen support on i2c2 bus.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 6e46a19..d7389b5 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -272,6 +272,16 @@
 	pinctrl-0 = <&pinctrl_i2c2>;
 	status = "okay";
 
+	touchscreen@4 {
+		compatible = "eeti,egalax_ts";
+		reg = <0x04>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_i2c2_egalax_int>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+		wakeup-gpios = <&gpio6 8 GPIO_ACTIVE_HIGH>;
+	};
+
 	ov5640: camera@3c {
 		compatible = "ovti,ov5640";
 		pinctrl-names = "default";
@@ -498,6 +508,12 @@
 			>;
 		};
 
+		pinctrl_i2c2_egalax_int: i2c2egalaxintgrp {
+			fsl,pins = <
+				MX6QDL_PAD_NANDF_ALE__GPIO6_IO08	0x1b0b0
+			>;
+		};
+
 		pinctrl_i2c3: i2c3grp {
 			fsl,pins = <
 				MX6QDL_PAD_GPIO_3__I2C3_SCL		0x4001b8b1
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus
  2018-12-04  8:54 [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus Anson Huang
@ 2018-12-04 10:19 ` Fabio Estevam
  2018-12-05  1:14   ` Anson Huang
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2018-12-04 10:19 UTC (permalink / raw)
  To: Yongcai Huang
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, NXP Linux Team

Hi Anson,

On Tue, Dec 4, 2018 at 6:54 AM Anson Huang <anson.huang@nxp.com> wrote:
>
> Add egalax touch screen support on i2c2 bus.

Please improve the commit log saying that this newly introduced
touchscreen controller is connected to LVDS0 and the existing one on
I2C3 is connected to LVDS1.

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus
  2018-12-04 10:19 ` Fabio Estevam
@ 2018-12-05  1:14   ` Anson Huang
  0 siblings, 0 replies; 3+ messages in thread
From: Anson Huang @ 2018-12-05  1:14 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
	Rob Herring, Mark Rutland,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, dl-linux-imx



Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: 2018年12月4日 18:19
> To: Anson Huang <anson.huang@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>; Fabio
> Estevam <fabio.estevam@nxp.com>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; moderated list:ARM/FREESCALE IMX
> / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>;
> dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen
> support on i2c2 bus
> 
> Hi Anson,
> 
> On Tue, Dec 4, 2018 at 6:54 AM Anson Huang <anson.huang@nxp.com>
> wrote:
> >
> > Add egalax touch screen support on i2c2 bus.
> 
> Please improve the commit log saying that this newly introduced touchscreen
> controller is connected to LVDS0 and the existing one on
> I2C3 is connected to LVDS1.
> 
> Thanks

Thanks Fabio, done in V2 patch.

Anson.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-05  1:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04  8:54 [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus Anson Huang
2018-12-04 10:19 ` Fabio Estevam
2018-12-05  1:14   ` Anson Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®