mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Gonzalez <alex.gonzalez@digi.com>
To: <hadess@hadess.net>
Cc: <dmitry.torokhov@gmail.com>, <linux-input@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <alex.gonzalez@digi.com>
Subject: [PATCH] Input: goodix - decouple irq and reset lines
Date: Fri, 4 Jan 2019 17:00:47 +0100	[thread overview]
Message-ID: <1546617648-23445-1-git-send-email-alex.gonzalez@digi.com> (raw)

The current implementation on the Goodix driver requires the two optional GPIOs
(RESET and INT) to be provided.

However, it is possible to designs the RESET line pulled-up and only provide
the INT line. Such designs do not work with the current implementation.

The patch attached allows for designs that only provide the INT line to have
a functional touch on the default I2C address, even though some functionality
like the sleep mode will not be available.

This has been tested on v4.20 with a gt911 based touch panel design that only
provides the INT line.

Alex Gonzalez (1):
  Input: goodix - decouple irq and reset lines

 drivers/input/touchscreen/goodix.c | 59 ++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 28 deletions(-)


             reply	other threads:[~2019-01-04 16:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 16:00 Alex Gonzalez [this message]
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 22:31   ` Andreas Gohr
2019-01-05 22:51   ` Dmitry Torokhov
2019-01-07 10:13     ` Gonzalez, Alex
2019-01-07 15:56     ` Bastien Nocera
2019-01-07 16:01       ` Bastien Nocera
2019-01-07 16:44         ` Gonzalez, Alex
2019-01-07 16:42       ` Gonzalez, Alex
2019-01-07 18:56         ` Dmitry Torokhov
2019-01-08 17:20           ` Gonzalez, Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546617648-23445-1-git-send-email-alex.gonzalez@digi.com \
    --to=alex.gonzalez@digi.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®