From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alex Gonzalez <alex.gonzalez@digi.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - decouple irq and reset lines
Date: Mon, 07 Jan 2019 17:01:56 +0100 [thread overview]
Message-ID: <5dfd17505a7c2f650f1102a8c0d7008ca8dc0b1f.camel@hadess.net> (raw)
In-Reply-To: <6b8f757eb52eb74d9dc2c3bedbfec798a58c0ec2.camel@hadess.net>
On Mon, 2019-01-07 at 16:56 +0100, Bastien Nocera wrote:
> Given that we do have access to the datasheet, it would also be
> useful
> for the patch to mention where in the datasheet it says that the
> reset
> line can be left pulled-up, or mention on which shipping device this
> setup is already used (and if so, what the DTS or ACPI snippet that
> declares those is).
Or alternatively, and as Andreas pointed out in another thread, find
the code in the vendor driver that does support this setup:
https://github.com/goodix/gt9xx_driver_android
https://github.com/goodix/goodix_gt9xx_public
If it doesn't work with the vendor code, then we might not want to make
it work with our driver either.
Cheers
next prev parent reply other threads:[~2019-01-07 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:00 Alex Gonzalez
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 22:31 ` Andreas Gohr
2019-01-05 22:51 ` Dmitry Torokhov
2019-01-07 10:13 ` Gonzalez, Alex
2019-01-07 15:56 ` Bastien Nocera
2019-01-07 16:01 ` Bastien Nocera [this message]
2019-01-07 16:44 ` Gonzalez, Alex
2019-01-07 16:42 ` Gonzalez, Alex
2019-01-07 18:56 ` Dmitry Torokhov
2019-01-08 17:20 ` Gonzalez, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dfd17505a7c2f650f1102a8c0d7008ca8dc0b1f.camel@hadess.net \
--to=hadess@hadess.net \
--cc=alex.gonzalez@digi.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®