From: "S, Shirish" <Shirish.S@amd.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
"maintainer : X86 ARCHITECTURE" <x86@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"open list : X86 ARCHITECTURE" <linux-kernel@vger.kernel.org>,
"S, Shirish" <Shirish.S@amd.com>
Subject: [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well
Date: Mon, 7 Jan 2019 10:37:24 +0000 [thread overview]
Message-ID: <1546857399-2926-3-git-send-email-shirish.s@amd.com> (raw)
In-Reply-To: <1546857399-2926-1-git-send-email-shirish.s@amd.com>
This patch adds threshold quirk applicable for family 15
in resume path as well, since mce_amd_feature_init()
does not have quirks applied when originating from mce_syscore_resume(),
resulting in the below message at every successful resume:
"[Firmware Bug]: cpu 0, invalid threshold interrupt offset ..."
Signed-off-by: Shirish S <shirish.s@amd.com>
---
arch/x86/kernel/cpu/mce/amd.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
index 89298c8..27cbf66 100644
--- a/arch/x86/kernel/cpu/mce/amd.c
+++ b/arch/x86/kernel/cpu/mce/amd.c
@@ -545,6 +545,34 @@ prepare_threshold_block(unsigned int bank, unsigned int block, u32 addr,
return offset;
}
+void disable_err_thresholding(struct cpuinfo_x86 *c)
+{
+ int i;
+ u64 hwcr;
+ bool need_toggle;
+ u32 msrs[] = {
+ 0x00000413, /* MC4_MISC0 */
+ 0xc0000408, /* MC4_MISC1 */
+ };
+
+ if (c->x86_model >= 0x10 && c->x86_model <= 0x7f) {
+ rdmsrl(MSR_K7_HWCR, hwcr);
+
+ /* McStatusWrEn has to be set */
+ need_toggle = !(hwcr & BIT(18));
+
+ if (need_toggle)
+ wrmsrl(MSR_K7_HWCR, hwcr | BIT(18));
+
+ /* Clear CntP bit safely */
+ for (i = 0; i < ARRAY_SIZE(msrs); i++)
+ msr_clear_bit(msrs[i], 62);
+
+ /* restore old settings */
+ if (need_toggle)
+ wrmsrl(MSR_K7_HWCR, hwcr);
+ }
+}
/* cpu init entry point, called from mce.c with preempt off */
void mce_amd_feature_init(struct cpuinfo_x86 *c)
{
@@ -552,6 +580,12 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
unsigned int bank, block, cpu = smp_processor_id();
int offset = -1;
+ /* Disable error thresholding bank in S3 resume path as well,
+ * for 15h family
+ */
+ if (c->x86 == 0x15)
+ disable_err_thresholding(c);
+
for (bank = 0; bank < mca_cfg.banks; ++bank) {
if (mce_flags.smca)
smca_configure(bank, cpu);
--
2.7.4
next prev parent reply other threads:[~2019-01-07 10:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 10:37 [PATCH 0/2] x86/mce/amd: apply missing quirks for family 15 models S, Shirish
2019-01-07 10:37 ` [PATCH 1/2] x86/mce/amd: Extend "Disable error thresholding bank 4" to more models S, Shirish
2019-01-09 21:54 ` Borislav Petkov
2019-01-10 8:02 ` S
2019-01-14 10:26 ` Borislav Petkov
2019-01-07 10:37 ` S, Shirish [this message]
2019-01-09 22:08 ` [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well Borislav Petkov
2019-01-10 8:04 ` S
2019-01-14 10:33 ` Borislav Petkov
2019-01-14 15:26 ` S
2019-01-14 15:32 ` Borislav Petkov
[not found] ` <4f8b532b-8613-feb5-7474-4bb0462cf1c7@amd.com>
2019-01-15 17:26 ` Borislav Petkov
2019-01-16 15:14 ` S
2019-01-16 15:26 ` Borislav Petkov
2019-01-16 15:31 ` S, Shirish
2019-01-16 15:36 ` S, Shirish
2019-01-16 15:38 ` Borislav Petkov
2019-01-07 11:24 ` [PATCH 0/2] x86/mce/amd: apply missing quirks for family 15 models Borislav Petkov
2019-01-07 15:13 ` S
[not found] <1546594609-22403-1-git-send-email-shirish.s@amd.com>
2019-01-04 9:37 ` [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well S, Shirish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546857399-2926-3-git-send-email-shirish.s@amd.com \
--to=shirish.s@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®