mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: S@vger.kernel.org
To: Borislav Petkov <bp@alien8.de>, "S, Shirish" <Shirish.S@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	"maintainer : X86 ARCHITECTURE" <x86@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"open list : X86 ARCHITECTURE" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well
Date: Mon, 14 Jan 2019 15:26:50 +0000	[thread overview]
Message-ID: <2ad4bb63-2b70-3652-3261-009cdbfc15a9@amd.com> (raw)
In-Reply-To: <20190114103312.GG2773@zn.tnic>


On 1/14/2019 4:03 PM, Borislav Petkov wrote:
> On Thu, Jan 10, 2019 at 08:04:49AM +0000, S wrote:
>> Perhaps no need to check the model altogether, this is applicable to
>> entire family 15, since there is no 8th Gen.
> I wouldn't be so sure. At the time I did this, we excluded models >=
> 0x10 but I don't remember why anymore. You need to check with hw folks
> whether you can really do this for the whole family.

I will get back with a thorough confirmation from the hw folks.

Since Yazen is on vacation, i will consult with him too once he is back.

Thanks for all the comments, i shall implement the same in case there 
would be another re-spin.

Regards,

Shirish S

>> I have summarized this sequence after capturing the call trace in both
>> scenarios.
>>
>> Its clear that the quirks are not applied during S3-> S0 transition,
>> hence the patch.
> Ok.
>
> Btw, fix your mailer: It has an empty from:
>
> From: S
>
> which, when I do "reply-to-all" here, generates an empty To: too.
>
> Thx.
>
-- 
Regards,
Shirish S


  reply	other threads:[~2019-01-14 15:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 10:37 [PATCH 0/2] x86/mce/amd: apply missing quirks for family 15 models S, Shirish
2019-01-07 10:37 ` [PATCH 1/2] x86/mce/amd: Extend "Disable error thresholding bank 4" to more models S, Shirish
2019-01-09 21:54   ` Borislav Petkov
2019-01-10  8:02     ` S
2019-01-14 10:26       ` Borislav Petkov
2019-01-07 10:37 ` [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well S, Shirish
2019-01-09 22:08   ` Borislav Petkov
2019-01-10  8:04     ` S
2019-01-14 10:33       ` Borislav Petkov
2019-01-14 15:26         ` S [this message]
2019-01-14 15:32           ` Borislav Petkov
     [not found]             ` <4f8b532b-8613-feb5-7474-4bb0462cf1c7@amd.com>
2019-01-15 17:26               ` Borislav Petkov
2019-01-16 15:14                 ` S
2019-01-16 15:26                   ` Borislav Petkov
2019-01-16 15:31                     ` S, Shirish
2019-01-16 15:36                       ` S, Shirish
2019-01-16 15:38                         ` Borislav Petkov
2019-01-07 11:24 ` [PATCH 0/2] x86/mce/amd: apply missing quirks for family 15 models Borislav Petkov
2019-01-07 15:13   ` S
     [not found] <1546594609-22403-1-git-send-email-shirish.s@amd.com>
2019-01-04  9:37 ` [PATCH 2/2] x86/mce/amd: Ensure quirks are applied in resume path as well S, Shirish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad4bb63-2b70-3652-3261-009cdbfc15a9@amd.com \
    --to=s@vger.kernel.org \
    --cc=Shirish.S@amd.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vishal.l.verma@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®