From: Hannes Eder <hannes@hanneseder.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: trivial@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH v2 15/15] NULL noise: mm/memcontrol.c
Date: Fri, 6 Mar 2009 00:04:49 +0100 [thread overview]
Message-ID: <154e089b0903051504v451f2421jae561c58984946ad@mail.gmail.com> (raw)
In-Reply-To: <20090305144210.e40ef501.akpm@linux-foundation.org>
On Thu, Mar 5, 2009 at 11:42 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 05 Mar 2009 20:18:44 +0100
> Hannes Eder <hannes@hanneseder.net> wrote:
>
>> Fix this sparse warning:
>> mm/memcontrol.c:1637:32: warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>> ---
>> v2: other subject, as suggested by Al Viro
>>
>> mm/memcontrol.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index 8e4be9c..09d6650 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -1634,7 +1634,7 @@ static int mem_cgroup_force_empty_list(struct mem_cgroup *mem,
>> pc = list_entry(list->prev, struct page_cgroup, lru);
>> if (busy == pc) {
>> list_move(&pc->lru, list);
>> - busy = 0;
>> + busy = NULL;
>> spin_unlock_irqrestore(&zone->lru_lock, flags);
>> continue;
>> }
>
> I have to say that I wish sparse didn't do this. Initialising a
> pointer with literal zero is perfectly clear and is idiomatic C.
We could turn it off with '-Wno-non-pointer-null', but then it is not
reported in other might useful cases either. Well, it's really a minor
thing, but fixing it, isn't a big deal either. Or is there any
drawback that I am not aware of?
prev parent reply other threads:[~2009-03-05 23:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 19:10 [PATCH v2 00/15] NULL noise fix: allmodconfig (x86_64), entire tree Hannes Eder
2009-03-05 19:12 ` [PATCH v2 01/15] NULL noise: arch/x86/kernel Hannes Eder
2009-03-05 19:13 ` [PATCH v2 02/15] NULL noise: arch/x86/kernel/amd_iommu*.c Hannes Eder
2009-03-05 19:53 ` [PATCH v3 " Hannes Eder
2009-03-05 19:13 ` [PATCH v2 03/15] NULL noise: arch/x86/xen/smp.c Hannes Eder
2009-03-05 20:15 ` Jeremy Fitzhardinge
2009-03-17 13:17 ` Jiri Kosina
2009-03-18 0:27 ` Jeremy Fitzhardinge
2009-03-18 10:28 ` Jiri Kosina
2009-03-05 19:14 ` [PATCH v2 04/15] NULL noise: drivers/gpu/drm/radeon/radeon_*.c Hannes Eder
2009-03-05 19:14 ` [PATCH v2 05/15] NULL noise: drivers/media/dvb/frontends/drx397xD_fw.h Hannes Eder
2009-03-09 10:58 ` Mauro Carvalho Chehab
2009-03-17 13:20 ` Jiri Kosina
2009-03-05 19:15 ` [PATCH v2 06/15] NULL noise: drivers/mtd/tests/mtd_*test.c Hannes Eder
2009-03-06 6:09 ` Artem Bityutskiy
2009-03-17 13:21 ` Jiri Kosina
2009-03-17 14:27 ` Artem Bityutskiy
2009-03-05 19:15 ` [PATCH v2 07/15] NULL noise: drivers/pci/dmar.c Hannes Eder
2009-03-05 19:15 ` [PATCH v2 08/15] NULL noise: drivers/platform/x86/panasonic-laptop.c Hannes Eder
2009-04-07 5:56 ` Len Brown
2009-03-05 19:16 ` [PATCH v2 09/15] NULL noise: drivers/scsi/FlashPoint.c Hannes Eder
2009-03-05 20:05 ` James Bottomley
2009-03-05 20:15 ` Hannes Eder
2009-03-05 21:55 ` [PATCH v3 " Hannes Eder
2009-03-05 21:58 ` [PATCH v2 " James Bottomley
2009-03-05 19:16 ` [PATCH v2 10/15] NULL noise: drivers/usb/host/oxu210hp-hcd.c Hannes Eder
2009-03-05 19:16 ` [PATCH v2 11/15] NULL noise: drivers/video/via/hw.c Hannes Eder
2009-03-05 19:17 ` [PATCH v2 12/15] NULL noise: fs/super.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 13/15] NULL noise: fs/reiserfs/inode.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 14/15] NULL noise: kernel/test_kprobes.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 15/15] NULL noise: mm/memcontrol.c Hannes Eder
2009-03-05 22:42 ` Andrew Morton
2009-03-05 23:04 ` Hannes Eder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0903051504v451f2421jae561c58984946ad@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®