From: Hannes Eder <hannes@hanneseder.net>
To: trivial@kernel.org
Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Joe Perches <joe@perches.com>
Subject: [PATCH v3 02/15] NULL noise: arch/x86/kernel/amd_iommu*.c
Date: Thu, 05 Mar 2009 20:53:42 +0100 [thread overview]
Message-ID: <20090305195228.2407.4911.stgit@f10box.hanneseder.net> (raw)
In-Reply-To: <20090305191312.30062.28919.stgit@f10box.hanneseder.net>
Fix this sparse warning(s):
arch/x86/kernel/amd_iommu_init.c:901:37: warning: Using plain integer as NULL pointer
arch/x86/kernel/amd_iommu.c:1522:24: warning: Using plain integer as NULL pointer
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
v2: other subject, as suggested by Al Viro
v3: no need to init the variable (thanks to Joe Perches)
arch/x86/kernel/amd_iommu.c | 2 +-
arch/x86/kernel/amd_iommu_init.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 008e522..3f6e1c8 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -1519,7 +1519,7 @@ static void *alloc_coherent(struct device *dev, size_t size,
flag |= __GFP_ZERO;
virt_addr = (void *)__get_free_pages(flag, get_order(size));
if (!virt_addr)
- return 0;
+ return NULL;
paddr = virt_to_phys(virt_addr);
diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 42c33ce..9bccd0f 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct ivmd_header *m)
/* called for unity map ACPI definition */
static int __init init_unity_map_range(struct ivmd_header *m)
{
- struct unity_map_entry *e = 0;
+ struct unity_map_entry *e;
e = kzalloc(sizeof(*e), GFP_KERNEL);
if (e == NULL)
next prev parent reply other threads:[~2009-03-05 19:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 19:10 [PATCH v2 00/15] NULL noise fix: allmodconfig (x86_64), entire tree Hannes Eder
2009-03-05 19:12 ` [PATCH v2 01/15] NULL noise: arch/x86/kernel Hannes Eder
2009-03-05 19:13 ` [PATCH v2 02/15] NULL noise: arch/x86/kernel/amd_iommu*.c Hannes Eder
2009-03-05 19:53 ` Hannes Eder [this message]
2009-03-05 19:13 ` [PATCH v2 03/15] NULL noise: arch/x86/xen/smp.c Hannes Eder
2009-03-05 20:15 ` Jeremy Fitzhardinge
2009-03-17 13:17 ` Jiri Kosina
2009-03-18 0:27 ` Jeremy Fitzhardinge
2009-03-18 10:28 ` Jiri Kosina
2009-03-05 19:14 ` [PATCH v2 04/15] NULL noise: drivers/gpu/drm/radeon/radeon_*.c Hannes Eder
2009-03-05 19:14 ` [PATCH v2 05/15] NULL noise: drivers/media/dvb/frontends/drx397xD_fw.h Hannes Eder
2009-03-09 10:58 ` Mauro Carvalho Chehab
2009-03-17 13:20 ` Jiri Kosina
2009-03-05 19:15 ` [PATCH v2 06/15] NULL noise: drivers/mtd/tests/mtd_*test.c Hannes Eder
2009-03-06 6:09 ` Artem Bityutskiy
2009-03-17 13:21 ` Jiri Kosina
2009-03-17 14:27 ` Artem Bityutskiy
2009-03-05 19:15 ` [PATCH v2 07/15] NULL noise: drivers/pci/dmar.c Hannes Eder
2009-03-05 19:15 ` [PATCH v2 08/15] NULL noise: drivers/platform/x86/panasonic-laptop.c Hannes Eder
2009-04-07 5:56 ` Len Brown
2009-03-05 19:16 ` [PATCH v2 09/15] NULL noise: drivers/scsi/FlashPoint.c Hannes Eder
2009-03-05 20:05 ` James Bottomley
2009-03-05 20:15 ` Hannes Eder
2009-03-05 21:55 ` [PATCH v3 " Hannes Eder
2009-03-05 21:58 ` [PATCH v2 " James Bottomley
2009-03-05 19:16 ` [PATCH v2 10/15] NULL noise: drivers/usb/host/oxu210hp-hcd.c Hannes Eder
2009-03-05 19:16 ` [PATCH v2 11/15] NULL noise: drivers/video/via/hw.c Hannes Eder
2009-03-05 19:17 ` [PATCH v2 12/15] NULL noise: fs/super.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 13/15] NULL noise: fs/reiserfs/inode.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 14/15] NULL noise: kernel/test_kprobes.c Hannes Eder
2009-03-05 19:18 ` [PATCH v2 15/15] NULL noise: mm/memcontrol.c Hannes Eder
2009-03-05 22:42 ` Andrew Morton
2009-03-05 23:04 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305195228.2407.4911.stgit@f10box.hanneseder.net \
--to=hannes@hanneseder.net \
--cc=joerg.roedel@amd.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®