* [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready
@ 2019-02-23 3:18 Anson Huang
2019-02-25 12:43 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Anson Huang @ 2019-02-23 3:18 UTC (permalink / raw)
To: linus.walleij, bgolaszewski, linux-gpio, linux-kernel; +Cc: dl-linux-imx
On i.MX8MQ platform, clock driver uses platform driver
model and it is probed after GPIO driver, so when GPIO
driver fails to get clock, it should check the error type
to decide whether to return defer probe or just ignore
the clock operation.
Fixes: 2808801aab8a ("gpio: mxc: add clock operation")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/gpio/gpio-mxc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 2d1dfa1..e86e61d 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -438,8 +438,11 @@ static int mxc_gpio_probe(struct platform_device *pdev)
/* the controller clock is optional */
port->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(port->clk))
+ if (IS_ERR(port->clk)) {
+ if (PTR_ERR(port->clk) == -EPROBE_DEFER)
+ return -EPROBE_DEFER;
port->clk = NULL;
+ }
err = clk_prepare_enable(port->clk);
if (err) {
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready
2019-02-23 3:18 [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready Anson Huang
@ 2019-02-25 12:43 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-02-25 12:43 UTC (permalink / raw)
To: Anson Huang; +Cc: bgolaszewski, linux-gpio, linux-kernel, dl-linux-imx
On Sat, Feb 23, 2019 at 4:18 AM Anson Huang <anson.huang@nxp.com> wrote:
> On i.MX8MQ platform, clock driver uses platform driver
> model and it is probed after GPIO driver, so when GPIO
> driver fails to get clock, it should check the error type
> to decide whether to return defer probe or just ignore
> the clock operation.
>
> Fixes: 2808801aab8a ("gpio: mxc: add clock operation")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-25 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 3:18 [PATCH] gpio: mxc: add check to return defer probe if clock tree NOT ready Anson Huang
2019-02-25 12:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®