From: Jeff Xie <chongguiguzi@gmail.com>
To: selvin.xavier@broadcom.com, devesh.sharma@broadcom.com
Cc: somnath.kotur@broadcom.com, chongguiguzi@gmail.com,
sriharsha.basavapatna@broadcom.com, dledford@redhat.com,
jgg@ziepe.ca, nux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet
Date: Wed, 20 Mar 2019 00:36:37 +0800 [thread overview]
Message-ID: <1553013397-29263-1-git-send-email-chongguiguzi@gmail.com> (raw)
It is unnecessary to call spin_lock_bh in a tasklet.
Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
---
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index 71c34d5..e2541c9 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -273,14 +273,14 @@ static void bnxt_qplib_service_nq(unsigned long data)
<< 32;
cq = (struct bnxt_qplib_cq *)(unsigned long)q_handle;
bnxt_qplib_arm_cq_enable(cq);
- spin_lock_bh(&cq->compl_lock);
+ spin_lock(&cq->compl_lock);
atomic_set(&cq->arm_state, 0);
if (!nq->cqn_handler(nq, (cq)))
num_cqne_processed++;
else
dev_warn(&nq->pdev->dev,
"cqn - type 0x%x not handled\n", type);
- spin_unlock_bh(&cq->compl_lock);
+ spin_unlock(&cq->compl_lock);
break;
}
case NQ_BASE_TYPE_SRQ_EVENT:
--
2.7.4
next reply other threads:[~2019-03-19 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:36 Jeff Xie [this message]
2019-03-19 19:22 ` Jason Gunthorpe
2019-03-20 0:49 ` 谢欢
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553013397-29263-1-git-send-email-chongguiguzi@gmail.com \
--to=chongguiguzi@gmail.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=nux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®