From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jeff Xie <chongguiguzi@gmail.com>
Cc: selvin.xavier@broadcom.com, devesh.sharma@broadcom.com,
somnath.kotur@broadcom.com, sriharsha.basavapatna@broadcom.com,
dledford@redhat.com, nux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet
Date: Tue, 19 Mar 2019 16:22:43 -0300 [thread overview]
Message-ID: <20190319192242.GA3773@ziepe.ca> (raw)
In-Reply-To: <1553013397-29263-1-git-send-email-chongguiguzi@gmail.com>
On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I'm curious, how did you prove this was always in a tasklet?
Jason
next prev parent reply other threads:[~2019-03-19 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:36 Jeff Xie
2019-03-19 19:22 ` Jason Gunthorpe [this message]
2019-03-20 0:49 ` 谢欢
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319192242.GA3773@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=chongguiguzi@gmail.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®