* Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() [not found] <1553497460-24166-1-git-send-email-chang-an.chen@mediatek.com> @ 2019-03-25 13:54 ` Thomas Gleixner 2019-03-29 2:30 ` Chang-An Chen 0 siblings, 1 reply; 2+ messages in thread From: Thomas Gleixner @ 2019-03-25 13:54 UTC (permalink / raw) To: Chang-An Chen Cc: Frederic Weisbecker, Ingo Molnar, Matthias Brugger, Pavel Tatashin, John Stultz, Kees Cook, Corey Minyard, linux-kernel, wsd_upstream, linux-mediatek, linux-arm-kernel, Stanley Chu, kuohong.wang On Mon, 25 Mar 2019, Chang-An Chen wrote: > --- a/include/linux/sched_clock.h > +++ b/include/linux/sched_clock.h > @@ -13,6 +13,10 @@ > > extern void sched_clock_register(u64 (*read)(void), int bits, > unsigned long rate); > + > +extern int sched_clock_suspend(void); > + > +extern void sched_clock_resume(void); > #else > static inline void generic_sched_clock_init(void) { } > > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits, > unsigned long rate) > { > } > + > +static int sched_clock_suspend(void) { } static inline ... > + > +static void sched_clock_resume(void) { } Ditto > #endif Please do not expose this in the global header. All of this is local to kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient. Thanks, tglx ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() 2019-03-25 13:54 ` [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() Thomas Gleixner @ 2019-03-29 2:30 ` Chang-An Chen 0 siblings, 0 replies; 2+ messages in thread From: Chang-An Chen @ 2019-03-29 2:30 UTC (permalink / raw) To: Thomas Gleixner Cc: Corey Minyard, Kees Cook, wsd_upstream, Frederic Weisbecker, Kuohong Wang (王國鴻), Pavel Tatashin, linux-kernel, John Stultz, Matthias Brugger, linux-mediatek, Stanley Chu (朱原陞), Ingo Molnar, linux-arm-kernel On Mon, 2019-03-25 at 21:54 +0800, Thomas Gleixner wrote: > On Mon, 25 Mar 2019, Chang-An Chen wrote: > > --- a/include/linux/sched_clock.h > > +++ b/include/linux/sched_clock.h > > @@ -13,6 +13,10 @@ > > > > extern void sched_clock_register(u64 (*read)(void), int bits, > > unsigned long rate); > > + > > +extern int sched_clock_suspend(void); > > + > > +extern void sched_clock_resume(void); > > #else > > static inline void generic_sched_clock_init(void) { } > > > > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits, > > unsigned long rate) > > { > > } > > + > > +static int sched_clock_suspend(void) { } > > static inline ... > > > + > > +static void sched_clock_resume(void) { } > > Ditto > > > #endif > > Please do not expose this in the global header. All of this is local to > kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient. Thanks so much for review and the suggestion, I'll fix it in next version. Thanks, Chang-An > > Thanks, > > tglx > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1553497460-24166-1-git-send-email-chang-an.chen@mediatek.com>
2019-03-25 13:54 ` [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() Thomas Gleixner
2019-03-29 2:30 ` Chang-An Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®