* [PATCH] x86/resctrl: Fix typos in mba_sc mount option
@ 2019-03-29 21:50 Xiaochen Shen
2019-04-01 16:53 ` [tip:x86/urgent] x86/resctrl: Fix typos in the " tip-bot for Xiaochen Shen
0 siblings, 1 reply; 2+ messages in thread
From: Xiaochen Shen @ 2019-03-29 21:50 UTC (permalink / raw)
To: tglx, linux-kernel, x86, tony.luck, fenghua.yu, reinette.chatre
Cc: dhowells, pei.p.jia, xiaochen.shen
With mount option "mba_MBps", we could enable MBA Software Controller
(mba_sc) to specify MBA memory bandwidth in unit MBps (Mega Bytes per
second). See details in Documentation/x86/resctrl_ui.txt.
Commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support
fs_context") changes the mount option from "mba_MBps" to "mba_mpbs" by
mistake.
Change back from "mba_mpbs" to "mba_MBps", and rename Opt_mba_mpbs to
Opt_mba_mbps.
Fixes: 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 399601e..54b9eef 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2039,14 +2039,14 @@ static int rdt_get_tree(struct fs_context *fc)
enum rdt_param {
Opt_cdp,
Opt_cdpl2,
- Opt_mba_mpbs,
+ Opt_mba_mbps,
nr__rdt_params
};
static const struct fs_parameter_spec rdt_param_specs[] = {
fsparam_flag("cdp", Opt_cdp),
fsparam_flag("cdpl2", Opt_cdpl2),
- fsparam_flag("mba_mpbs", Opt_mba_mpbs),
+ fsparam_flag("mba_MBps", Opt_mba_mbps),
{}
};
@@ -2072,7 +2072,7 @@ static int rdt_parse_param(struct fs_context *fc, struct fs_parameter *param)
case Opt_cdpl2:
ctx->enable_cdpl2 = true;
return 0;
- case Opt_mba_mpbs:
+ case Opt_mba_mbps:
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
return -EINVAL;
ctx->enable_mba_mbps = true;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86/resctrl: Fix typos in the mba_sc mount option
2019-03-29 21:50 [PATCH] x86/resctrl: Fix typos in mba_sc mount option Xiaochen Shen
@ 2019-04-01 16:53 ` tip-bot for Xiaochen Shen
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Xiaochen Shen @ 2019-04-01 16:53 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, mingo, mingo, reinette.chatre, x86, bp, xiaochen.shen,
fenghua.yu, linux-kernel, tony.luck, hpa
Commit-ID: faa3604eda325588451c9c1eb4c8a8d04c1cd633
Gitweb: https://git.kernel.org/tip/faa3604eda325588451c9c1eb4c8a8d04c1cd633
Author: Xiaochen Shen <xiaochen.shen@intel.com>
AuthorDate: Sat, 30 Mar 2019 05:50:38 +0800
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Mon, 1 Apr 2019 18:45:27 +0200
x86/resctrl: Fix typos in the mba_sc mount option
The user can control the MBA memory bandwidth in MBps (Mega
Bytes per second) units of the MBA Software Controller (mba_sc)
by using the "mba_MBps" mount option. For details, see
Documentation/x86/resctrl_ui.txt.
However, commit
23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
changed the mount option name from "mba_MBps" to "mba_mpbs" by mistake.
Change it back from to "mba_MBps" because it is user-visible, and
correct "Opt_mba_mpbs" spelling to "Opt_mba_mbps".
[ bp: massage commit message. ]
Fixes: 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: dhowells@redhat.com
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: pei.p.jia@intel.com
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/1553896238-22130-1-git-send-email-xiaochen.shen@intel.com
---
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 399601eda8e4..54b9eef3eea9 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2039,14 +2039,14 @@ out:
enum rdt_param {
Opt_cdp,
Opt_cdpl2,
- Opt_mba_mpbs,
+ Opt_mba_mbps,
nr__rdt_params
};
static const struct fs_parameter_spec rdt_param_specs[] = {
fsparam_flag("cdp", Opt_cdp),
fsparam_flag("cdpl2", Opt_cdpl2),
- fsparam_flag("mba_mpbs", Opt_mba_mpbs),
+ fsparam_flag("mba_MBps", Opt_mba_mbps),
{}
};
@@ -2072,7 +2072,7 @@ static int rdt_parse_param(struct fs_context *fc, struct fs_parameter *param)
case Opt_cdpl2:
ctx->enable_cdpl2 = true;
return 0;
- case Opt_mba_mpbs:
+ case Opt_mba_mbps:
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
return -EINVAL;
ctx->enable_mba_mbps = true;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-01 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 21:50 [PATCH] x86/resctrl: Fix typos in mba_sc mount option Xiaochen Shen
2019-04-01 16:53 ` [tip:x86/urgent] x86/resctrl: Fix typos in the " tip-bot for Xiaochen Shen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome