mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kbuild: Fix cross compile link with ccache
@ 2019-05-06 12:40 Krzysztof Kozlowski
  2019-05-06 12:43 ` Krzysztof Kozlowski
  2019-05-06 14:10 ` Masahiro Yamada
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2019-05-06 12:40 UTC (permalink / raw)
  To: Masahiro Yamada, Daniel Borkmann, Andrii Nakryiko,
	Alexei Starovoitov, Gleb Fotengauer-Malinovskiy, Alexey Gladkov,
	Krzysztof Kozlowski, linux-kernel
  Cc: Jessica Yu

Fix calling objcopy in case of cross compile environments:

	ARCH="arm" CROSS_COMPILE="ccache arm-linux-gnueabi-" make
	scripts/link-vmlinux.sh: line 211: ccache arm-linux-gnueabi-objcopy: command not found

Fixes: 6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 scripts/link-vmlinux.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 62b9fc561af7..42ea6f9264ef 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -208,7 +208,7 @@ modpost_link vmlinux.o
 ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o
 
 info MODINFO modules.builtin.modinfo
-"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
+${OBJCOPY} -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
 
 kallsymso=""
 kallsyms_vmlinux=""
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: Fix cross compile link with ccache
  2019-05-06 12:40 [PATCH] kbuild: Fix cross compile link with ccache Krzysztof Kozlowski
@ 2019-05-06 12:43 ` Krzysztof Kozlowski
  2019-05-06 14:10 ` Masahiro Yamada
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2019-05-06 12:43 UTC (permalink / raw)
  To: Masahiro Yamada, Daniel Borkmann, Andrii Nakryiko,
	Alexei Starovoitov, Gleb Fotengauer-Malinovskiy, Alexey Gladkov,
	Krzysztof Kozlowski, linux-kernel
  Cc: Jessica Yu, Michal Marek, linux-kbuild

+cc linux-kbuild@vger.kernel.org, Michal Marek (somehow
get_maintainers did not mention them)

On Mon, 6 May 2019 at 14:40, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Fix calling objcopy in case of cross compile environments:
>
>         ARCH="arm" CROSS_COMPILE="ccache arm-linux-gnueabi-" make
>         scripts/link-vmlinux.sh: line 211: ccache arm-linux-gnueabi-objcopy: command not found
>
> Fixes: 6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  scripts/link-vmlinux.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 62b9fc561af7..42ea6f9264ef 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -208,7 +208,7 @@ modpost_link vmlinux.o
>  ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o
>
>  info MODINFO modules.builtin.modinfo
> -"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
> +${OBJCOPY} -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
>
>  kallsymso=""
>  kallsyms_vmlinux=""
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: Fix cross compile link with ccache
  2019-05-06 12:40 [PATCH] kbuild: Fix cross compile link with ccache Krzysztof Kozlowski
  2019-05-06 12:43 ` Krzysztof Kozlowski
@ 2019-05-06 14:10 ` Masahiro Yamada
  1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-05-06 14:10 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Daniel Borkmann, Andrii Nakryiko, Alexei Starovoitov,
	Gleb Fotengauer-Malinovskiy, Alexey Gladkov,
	Linux Kernel Mailing List, Jessica Yu

Hi Krzysztof,


On Mon, May 6, 2019 at 9:41 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Fix calling objcopy in case of cross compile environments:
>
>         ARCH="arm" CROSS_COMPILE="ccache arm-linux-gnueabi-" make
>         scripts/link-vmlinux.sh: line 211: ccache arm-linux-gnueabi-objcopy: command not found
>
> Fixes: 6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")


Thanks for the report.

I need to drop this commit from my tree for now
and re-spin as Stephen reported some build breakage:

https://lkml.org/lkml/2019/5/5/269


I will squash this when I re-add the former patch.

Thanks.





> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  scripts/link-vmlinux.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 62b9fc561af7..42ea6f9264ef 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -208,7 +208,7 @@ modpost_link vmlinux.o
>  ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o
>
>  info MODINFO modules.builtin.modinfo
> -"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
> +${OBJCOPY} -j .modinfo -O binary vmlinux.o modules.builtin.modinfo
>
>  kallsymso=""
>  kallsyms_vmlinux=""
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-06 14:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 12:40 [PATCH] kbuild: Fix cross compile link with ccache Krzysztof Kozlowski
2019-05-06 12:43 ` Krzysztof Kozlowski
2019-05-06 14:10 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®