From: Robert Hancock <hancock@sedsystems.ca>
To: linux-kernel@vger.kernel.org
Cc: lee.jones@linaro.org, Robert Hancock <hancock@sedsystems.ca>
Subject: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type
Date: Tue, 4 Jun 2019 16:35:42 -0600 [thread overview]
Message-ID: <1559687743-31879-2-git-send-email-hancock@sedsystems.ca> (raw)
In-Reply-To: <1559687743-31879-1-git-send-email-hancock@sedsystems.ca>
Previously the MFD core supported assigning OF nodes to created MFD
devices, but relied solely on matching the of_compatible string. This
would result in devices being potentially assigned the wrong node if
there are multiple devices with the same compatible string within a
multifunction device.
Add support for matching the full name of the node in the MFD cell
definition, so that we can match against a specific instance of a
device. If this is not specified, we match just based on the
compatible string, as before.
Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
drivers/mfd/mfd-core.c | 5 ++++-
include/linux/mfd/core.h | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 1ade4c8..74bc895 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -177,7 +177,10 @@ static int mfd_add_device(struct device *parent, int id,
if (parent->of_node && cell->of_compatible) {
for_each_child_of_node(parent->of_node, np) {
- if (of_device_is_compatible(np, cell->of_compatible)) {
+ if (of_device_is_compatible(np, cell->of_compatible) &&
+ (!cell->of_full_name ||
+ !strcmp(cell->of_full_name,
+ of_node_full_name(np)))) {
pdev->dev.of_node = np;
break;
}
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index 99c0395..470f6cb 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -55,6 +55,9 @@ struct mfd_cell {
*/
const char *of_compatible;
+ /* Optionally match against a specific device of a given type */
+ const char *of_full_name;
+
/* Matches ACPI */
const struct mfd_cell_acpi_match *acpi_match;
--
1.8.3.1
next prev parent reply other threads:[~2019-06-04 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 22:35 [PATCH 0/2] MFD core updates for device tree binding support Robert Hancock
2019-06-04 22:35 ` Robert Hancock [this message]
2019-06-05 6:31 ` [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type Lee Jones
2019-06-05 16:23 ` Robert Hancock
2019-06-05 18:45 ` Lee Jones
2019-06-05 19:26 ` Robert Hancock
2019-06-06 5:27 ` Lee Jones
2019-06-06 15:33 ` Robert Hancock
2019-06-10 8:08 ` Lee Jones
2019-06-04 22:35 ` [PATCH 2/2] mfd: core: Set fwnode for created devices Robert Hancock
2019-06-05 6:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559687743-31879-2-git-send-email-hancock@sedsystems.ca \
--to=hancock@sedsystems.ca \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®