From: Robert Hancock <hancock@sedsystems.ca>
To: linux-kernel@vger.kernel.org
Cc: lee.jones@linaro.org, Robert Hancock <hancock@sedsystems.ca>
Subject: [PATCH 2/2] mfd: core: Set fwnode for created devices
Date: Tue, 4 Jun 2019 16:35:43 -0600 [thread overview]
Message-ID: <1559687743-31879-3-git-send-email-hancock@sedsystems.ca> (raw)
In-Reply-To: <1559687743-31879-1-git-send-email-hancock@sedsystems.ca>
The logic for setting the of_node on devices created by mfd did not set
the fwnode pointer to match, which caused fwnode-based APIs to
malfunction on these devices since the fwnode pointer was null. Fix
this.
Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
drivers/mfd/mfd-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 74bc895..228163c 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -182,6 +182,7 @@ static int mfd_add_device(struct device *parent, int id,
!strcmp(cell->of_full_name,
of_node_full_name(np)))) {
pdev->dev.of_node = np;
+ pdev->dev.fwnode = &np->fwnode;
break;
}
}
--
1.8.3.1
next prev parent reply other threads:[~2019-06-04 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 22:35 [PATCH 0/2] MFD core updates for device tree binding support Robert Hancock
2019-06-04 22:35 ` [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type Robert Hancock
2019-06-05 6:31 ` Lee Jones
2019-06-05 16:23 ` Robert Hancock
2019-06-05 18:45 ` Lee Jones
2019-06-05 19:26 ` Robert Hancock
2019-06-06 5:27 ` Lee Jones
2019-06-06 15:33 ` Robert Hancock
2019-06-10 8:08 ` Lee Jones
2019-06-04 22:35 ` Robert Hancock [this message]
2019-06-05 6:31 ` [PATCH 2/2] mfd: core: Set fwnode for created devices Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559687743-31879-3-git-send-email-hancock@sedsystems.ca \
--to=hancock@sedsystems.ca \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®