mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Divya Indi <divya.indi@oracle.com>
To: linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: Divya Indi <divya.indi@oracle.com>, Joe Jin <joe.jin@oracle.com>,
	Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
	Srinivas Eeda <srinivas.eeda@oracle.com>
Subject: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event
Date: Mon, 29 Jul 2019 17:02:34 -0700	[thread overview]
Message-ID: <1564444954-28685-8-git-send-email-divya.indi@oracle.com> (raw)
In-Reply-To: <1564444954-28685-1-git-send-email-divya.indi@oracle.com>

Use "trace_array_set_clr_event" to enable/disable events to a trace
array from other kernel modules/components.
Hence, we no longer need to have ftrace_set_clr_event as an exported API.

Signed-off-by: Divya Indi <divya.indi@oracle.com>
Reviewed-By: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
---
 include/linux/trace_events.h | 1 -
 kernel/trace/trace_events.c  | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 6da3600..025ae2b 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -542,7 +542,6 @@ extern int trace_define_field(struct trace_event_call *call, const char *type,
 int trace_set_clr_event(const char *system, const char *event, int set);
 int trace_array_set_clr_event(struct trace_array *tr, const char *system,
 		const char *event, int set);
-int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set);
 
 /*
  * The double __builtin_constant_p is because gcc will give us an error
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 9ee6b52..96dd997 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -795,7 +795,7 @@ static int __ftrace_set_clr_event(struct trace_array *tr, const char *match,
 	return ret;
 }
 
-int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
+static int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
 {
 	char *event = NULL, *sub = NULL, *match;
 	int ret;
@@ -834,7 +834,6 @@ int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(ftrace_set_clr_event);
 
 /**
  * trace_set_clr_event - enable or disable an event
-- 
1.8.3.1


  parent reply	other threads:[~2019-07-30  0:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  0:02 [PATCH 0/7[v3]] Kernel access to Ftrace instances Divya Indi
2019-07-30  0:02 ` [PATCH 1/7] tracing: Required changes to use ftrace_set_clr_event Divya Indi
2019-07-30  0:02 ` [PATCH 2/7] tracing: Declare newly exported APIs in include/linux/trace.h Divya Indi
2019-07-30  0:02 ` [PATCH 3/7] tracing: Verify if trace array exists before destroying it Divya Indi
2019-07-30  0:02 ` [PATCH 4/7] tracing: Adding NULL checks Divya Indi
2019-07-30  0:02 ` [PATCH 5/7] tracing: Handle the trace array ref counter in new functions Divya Indi
2019-07-30  0:02 ` [PATCH 6/7] tracing: New functions for kernel access to Ftrace instances Divya Indi
2019-07-30  0:02 ` Divya Indi [this message]
2019-07-30  0:51   ` [PATCH 7/7] tracing: Un-export ftrace_set_clr_event Steven Rostedt
2019-07-30 22:29     ` Divya Indi
2019-08-02 17:42       ` Steven Rostedt
     [not found]         ` <291a12f6-e1eb-052e-0dd6-0e649dd4a752@oracle.com>
2019-08-02 20:46           ` Steven Rostedt
2019-08-02 21:12             ` Divya Indi
2019-08-02 21:25               ` Steven Rostedt
2019-08-07 18:13                 ` Divya Indi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564444954-28685-8-git-send-email-divya.indi@oracle.com \
    --to=divya.indi@oracle.com \
    --cc=aruna.ramakrishna@oracle.com \
    --cc=joe.jin@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srinivas.eeda@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®