From: Steven Rostedt <rostedt@goodmis.org>
To: Divya Indi <divya.indi@oracle.com>
Cc: linux-kernel@vger.kernel.org, Joe Jin <joe.jin@oracle.com>,
Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
Srinivas Eeda <srinivas.eeda@oracle.com>
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event
Date: Fri, 2 Aug 2019 13:42:28 -0400 [thread overview]
Message-ID: <20190802134229.2a969047@gandalf.local.home> (raw)
In-Reply-To: <8e50d405-a4fb-fadf-509e-157b031d7542@oracle.com>
On Tue, 30 Jul 2019 15:29:41 -0700
Divya Indi <divya.indi@oracle.com> wrote:
> Hi Steven,
>
> On 7/29/19 5:51 PM, Steven Rostedt wrote:
> > On Mon, 29 Jul 2019 17:02:34 -0700
> > Divya Indi <divya.indi@oracle.com> wrote:
> >
> >> Use "trace_array_set_clr_event" to enable/disable events to a trace
> >> array from other kernel modules/components.
> >> Hence, we no longer need to have ftrace_set_clr_event as an exported API.
> > Hmm, this simply reverts patch 1. Why have patch 1 and this patch in
> > the first place?
>
> Right! First patch fixes issues in a previous commit and then this patch
> reverts the part of previous commit that required the fix.
>
> We can eliminate the first patch if it seems counter intuitive.
>
>
As a stand alone patch, the first one may be fine. But as part of a
series, it doesn't make sense to add it.
-- Steve
next prev parent reply other threads:[~2019-08-02 17:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 0:02 [PATCH 0/7[v3]] Kernel access to Ftrace instances Divya Indi
2019-07-30 0:02 ` [PATCH 1/7] tracing: Required changes to use ftrace_set_clr_event Divya Indi
2019-07-30 0:02 ` [PATCH 2/7] tracing: Declare newly exported APIs in include/linux/trace.h Divya Indi
2019-07-30 0:02 ` [PATCH 3/7] tracing: Verify if trace array exists before destroying it Divya Indi
2019-07-30 0:02 ` [PATCH 4/7] tracing: Adding NULL checks Divya Indi
2019-07-30 0:02 ` [PATCH 5/7] tracing: Handle the trace array ref counter in new functions Divya Indi
2019-07-30 0:02 ` [PATCH 6/7] tracing: New functions for kernel access to Ftrace instances Divya Indi
2019-07-30 0:02 ` [PATCH 7/7] tracing: Un-export ftrace_set_clr_event Divya Indi
2019-07-30 0:51 ` Steven Rostedt
2019-07-30 22:29 ` Divya Indi
2019-08-02 17:42 ` Steven Rostedt [this message]
[not found] ` <291a12f6-e1eb-052e-0dd6-0e649dd4a752@oracle.com>
2019-08-02 20:46 ` Steven Rostedt
2019-08-02 21:12 ` Divya Indi
2019-08-02 21:25 ` Steven Rostedt
2019-08-07 18:13 ` Divya Indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802134229.2a969047@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=aruna.ramakrishna@oracle.com \
--cc=divya.indi@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.eeda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®