From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>, Pavel Machek <pavel@ucw.cz>,
LKML <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
Len Brown <len.brown@intel.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable
Date: Mon, 16 Jun 2014 01:04:42 +0200 [thread overview]
Message-ID: <1565726.7T8Lt3Xc6J@vostro.rjw.lan> (raw)
In-Reply-To: <539C7B2F.9070800@zytor.com>
On Saturday, June 14, 2014 09:41:19 AM H. Peter Anvin wrote:
> On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote:
> >
> > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL
> > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL
> >
>
> <bikeshed>
>
> Please don't pick numbers like this for magic numbers... *everyone else
> does, too.* In general, picking a random number is a good starting
> point; for extra bonus make sure it has at least one invalid UTF-8
> sequence in it (so it cannot be confused with either ASCII or UTF-8 text.)
>
> </bikeshed>
OK, when we find out how to make hibernation work with the address space
randomization.
Rafael
next prev parent reply other threads:[~2014-06-15 22:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:46 Kees Cook
2014-06-12 19:46 ` [PATCH 1/2] hibernate: create one-way disable mode Kees Cook
2014-06-12 20:12 ` Rafael J. Wysocki
2014-06-12 19:46 ` [PATCH 2/2] x86, kaslr: boot-time selectable with hibernation Kees Cook
2014-06-12 19:48 ` [PATCH 0/2] make kASLR vs hibernation boot-time selectable H. Peter Anvin
2014-06-12 20:13 ` Rafael J. Wysocki
2014-06-12 20:27 ` Kees Cook
2014-06-12 20:29 ` H. Peter Anvin
2014-06-12 20:58 ` Kees Cook
2014-06-13 10:51 ` Pavel Machek
2014-06-13 17:32 ` Kees Cook
2014-06-13 17:36 ` H. Peter Anvin
2014-06-13 20:26 ` Pavel Machek
2014-06-13 22:14 ` Rafael J. Wysocki
2014-06-13 22:07 ` Kees Cook
2014-06-13 22:54 ` Rafael J. Wysocki
2014-06-13 22:59 ` Kees Cook
2014-06-14 0:14 ` Rafael J. Wysocki
2014-06-14 0:08 ` Kees Cook
2014-06-14 0:39 ` Rafael J. Wysocki
2014-06-14 7:37 ` Kees Cook
2014-06-15 23:16 ` Rafael J. Wysocki
2014-06-14 16:41 ` H. Peter Anvin
2014-06-15 23:04 ` Rafael J. Wysocki [this message]
2014-06-14 2:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565726.7T8Lt3Xc6J@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®