* [PATCH 3/3] dmaengine: imx-sdma: remove unused function
@ 2016-09-24 5:01 Baoyou Xie
2016-09-24 8:59 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-24 5:01 UTC (permalink / raw)
To: dan.j.williams, vinod.koul
Cc: dmaengine, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/dma/imx-sdma.c:673:13: warning: 'sdma_handle_channel_loop' defined but not used [-Wunused-function]
In fact, this function is called by no one and not exported,
so this patch removes it.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/dma/imx-sdma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 695f160..7fb55dd 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -670,11 +670,6 @@ static void sdma_event_disable(struct sdma_channel *sdmac, unsigned int event)
writel_relaxed(val, sdma->regs + chnenbl);
}
-static void sdma_handle_channel_loop(struct sdma_channel *sdmac)
-{
- dmaengine_desc_get_callback_invoke(&sdmac->desc, NULL);
-}
-
static void sdma_update_channel_loop(struct sdma_channel *sdmac)
{
struct sdma_buffer_descriptor *bd;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/3] dmaengine: imx-sdma: remove unused function
2016-09-24 5:01 [PATCH 3/3] dmaengine: imx-sdma: remove unused function Baoyou Xie
@ 2016-09-24 8:59 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-24 8:59 UTC (permalink / raw)
To: Baoyou Xie
Cc: dan.j.williams, vinod.koul, dmaengine, linux-kernel, xie.baoyou
On Saturday, September 24, 2016 1:01:06 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/dma/imx-sdma.c:673:13: warning: 'sdma_handle_channel_loop' defined but not used [-Wunused-function]
>
> In fact, this function is called by no one and not exported,
> so this patch removes it.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
The warning also shows up without W=1. I submitted the same patch,
and it was applied on Thursday.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-24 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-24 5:01 [PATCH 3/3] dmaengine: imx-sdma: remove unused function Baoyou Xie
2016-09-24 8:59 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®