mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krishna Yarlagadda <kyarlagadda@nvidia.com>
To: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <thierry.reding@gmail.com>,
	<jonathanh@nvidia.com>, <ldewangan@nvidia.com>, <jslaby@suse.com>
Cc: <linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Shardar Shariff Md <smohammed@nvidia.com>,
	Krishna Yarlagadda <kyarlagadda@nvidia.com>
Subject: [PATCH V2 03/12] serial: tegra: flush the RX fifo on frame error
Date: Wed, 4 Sep 2019 10:12:58 +0530	[thread overview]
Message-ID: <1567572187-29820-4-git-send-email-kyarlagadda@nvidia.com> (raw)
In-Reply-To: <1567572187-29820-1-git-send-email-kyarlagadda@nvidia.com>

From: Shardar Shariff Md <smohammed@nvidia.com>

FIFO reset/flush code implemented now does not follow programming
guidelines. RTS line has to be turned off while flushing FIFOs to
avoid new transfers. Also check LSR bits UART_LSR_TEMT and UART_LSR_DR
to confirm FIFOs are flushed.

Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
---
 drivers/tty/serial/serial-tegra.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index 29bf7b7..4cd6d5f 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -266,6 +266,10 @@ static void tegra_uart_wait_sym_time(struct tegra_uart_port *tup,
 static void tegra_uart_fifo_reset(struct tegra_uart_port *tup, u8 fcr_bits)
 {
 	unsigned long fcr = tup->fcr_shadow;
+	unsigned int lsr, tmout = 10000;
+
+	if (tup->rts_active)
+		set_rts(tup, false);
 
 	if (tup->cdata->allow_txfifo_reset_fifo_mode) {
 		fcr |= fcr_bits & (UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT);
@@ -289,6 +293,16 @@ static void tegra_uart_fifo_reset(struct tegra_uart_port *tup, u8 fcr_bits)
 	 * to propagate, otherwise data could be lost.
 	 */
 	tegra_uart_wait_cycle_time(tup, 32);
+
+	do {
+		lsr = tegra_uart_read(tup, UART_LSR);
+		if ((lsr | UART_LSR_TEMT) && !(lsr & UART_LSR_DR))
+			break;
+		udelay(1);
+	} while (--tmout);
+
+	if (tup->rts_active)
+		set_rts(tup, true);
 }
 
 static int tegra_set_baudrate(struct tegra_uart_port *tup, unsigned int baud)
-- 
2.7.4


  parent reply	other threads:[~2019-09-04  4:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  4:42 [PATCH V2 00/12] serial: tegra: Tegra186 support and fixes Krishna Yarlagadda
2019-09-04  4:42 ` [PATCH V2 01/12] serial: tegra: add support to ignore read Krishna Yarlagadda
2019-09-04  4:42 ` [PATCH V2 02/12] serial: tegra: avoid reg access when clk disabled Krishna Yarlagadda
2019-09-04  4:42 ` Krishna Yarlagadda [this message]
2019-09-04  4:42 ` [PATCH V2 04/12] serial: tegra: report error to upper tty layer Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 05/12] dt-binding: serial: tegra: add new chips Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 06/12] serial: tegra: check for FIFO mode enabled status Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 07/12] serial: tegra: set maximum num of uart ports to 8 Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 08/12] serial: tegra: add support to use 8 bytes trigger Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 09/12] serial: tegra: DT for Adjusted baud rates Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 10/12] serial: tegra: add support to adjust baud rate Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 11/12] serial: tegra: report clk rate errors Krishna Yarlagadda
2019-09-04  4:43 ` [PATCH V2 12/12] serial: tegra: Add PIO mode support Krishna Yarlagadda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567572187-29820-4-git-send-email-kyarlagadda@nvidia.com \
    --to=kyarlagadda@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=jslaby@suse.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=smohammed@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®