mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: dt-bindings: Fix building error for dt_binding_check
@ 2019-09-18 14:02 Pragnesh Patel
  2019-09-18 14:27 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Pragnesh Patel @ 2019-09-18 14:02 UTC (permalink / raw)
  To: lgirdwood, broonie
  Cc: Pragnesh Patel, Rob Herring, Mark Rutland, linux-kernel, devicetree

Compatible property is not of type 'string' so replace enum
with items.

Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
---
 Documentation/devicetree/bindings/regulator/fixed-regulator.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
index a78150c..8d4a7b2 100644
--- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
@@ -29,7 +29,7 @@ if:
 
 properties:
   compatible:
-    enum:
+    items:
       - const: regulator-fixed
       - const: regulator-fixed-clock
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: dt-bindings: Fix building error for dt_binding_check
  2019-09-18 14:02 [PATCH] regulator: dt-bindings: Fix building error for dt_binding_check Pragnesh Patel
@ 2019-09-18 14:27 ` Rob Herring
  2019-09-18 18:24   ` Pragnesh Patel
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2019-09-18 14:27 UTC (permalink / raw)
  To: Pragnesh Patel
  Cc: Liam Girdwood, Mark Brown, Mark Rutland, linux-kernel, devicetree

On Wed, Sep 18, 2019 at 9:02 AM Pragnesh Patel
<pragnesh.patel@sifive.com> wrote:
>

The subject could be more specific rather than being one that applies
to any dt_binding_check breakage in regulators.

> Compatible property is not of type 'string' so replace enum
> with items.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> ---
>  Documentation/devicetree/bindings/regulator/fixed-regulator.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index a78150c..8d4a7b2 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> @@ -29,7 +29,7 @@ if:
>
>  properties:
>    compatible:
> -    enum:
> +    items:
>        - const: regulator-fixed
>        - const: regulator-fixed-clock

This means you expect: compatible = "regulator-fixed", "regulator-fixed-clock";

Did you actually run 'dt_binding_check' because it should fail on the example?

I gave you exact change to make. Just remove 'const: ' on each entry.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: dt-bindings: Fix building error for dt_binding_check
  2019-09-18 14:27 ` Rob Herring
@ 2019-09-18 18:24   ` Pragnesh Patel
  0 siblings, 0 replies; 3+ messages in thread
From: Pragnesh Patel @ 2019-09-18 18:24 UTC (permalink / raw)
  To: Rob Herring
  Cc: Liam Girdwood, Mark Brown, Mark Rutland, linux-kernel, devicetree

On Wed, Sep 18, 2019 at 7:58 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Wed, Sep 18, 2019 at 9:02 AM Pragnesh Patel
> <pragnesh.patel@sifive.com> wrote:
> >
>
> The subject could be more specific rather than being one that applies
> to any dt_binding_check breakage in regulators.
>

Thanks for pointing me out, I will take care this in future patches.

> > Compatible property is not of type 'string' so replace enum
> > with items.
> >
> > Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> > ---
> >  Documentation/devicetree/bindings/regulator/fixed-regulator.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> > index a78150c..8d4a7b2 100644
> > --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> > @@ -29,7 +29,7 @@ if:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > +    items:
> >        - const: regulator-fixed
> >        - const: regulator-fixed-clock
>
> This means you expect: compatible = "regulator-fixed", "regulator-fixed-clock";
>
> Did you actually run 'dt_binding_check' because it should fail on the example?
>
> I gave you exact change to make. Just remove 'const: ' on each entry.

Thanks for correcting me, i rechecked "make dt_binding_check" and it's failed.
I will send the patch again with the updated subject line.

>
> Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-18 18:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18 14:02 [PATCH] regulator: dt-bindings: Fix building error for dt_binding_check Pragnesh Patel
2019-09-18 14:27 ` Rob Herring
2019-09-18 18:24   ` Pragnesh Patel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®