From: Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>
To: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"gklkml16@gmail.com" <gklkml16@gmail.com>
Subject: [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing
Date: Wed, 6 Nov 2019 01:01:40 +0000 [thread overview]
Message-ID: <1573002091-9744-2-git-send-email-gkulkarni@marvell.com> (raw)
In-Reply-To: <1573002091-9744-1-git-send-email-gkulkarni@marvell.com>
When PMUs are registered, perf core enables event multiplexing
support by default. There is no provision for PMUs to disable
event multiplexing, if PMUs want to disable due to unavoidable
circumstances like hardware errata etc.
Adding PMU capability flag PERF_PMU_CAP_NO_MUX_EVENTS and support
to allow PMUs to explicitly disable event multiplexing.
Signed-off-by: Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>
---
include/linux/perf_event.h | 1 +
kernel/events/core.c | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 61448c19a132..9e18d841daf7 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -247,6 +247,7 @@ struct perf_event;
#define PERF_PMU_CAP_HETEROGENEOUS_CPUS 0x40
#define PERF_PMU_CAP_NO_EXCLUDE 0x80
#define PERF_PMU_CAP_AUX_OUTPUT 0x100
+#define PERF_PMU_CAP_NO_MUX_EVENTS 0x200
/**
* struct pmu - generic performance monitoring unit
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 4655adbbae10..65452784f81c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -1092,6 +1092,10 @@ static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
if (pmu->task_ctx_nr == perf_sw_context)
return;
+ /* No PMU support */
+ if (pmu->capabilities & PERF_PMU_CAP_NO_MUX_EVENTS)
+ return 0;
+
/*
* check default is sane, if not set then force to
* default interval (1/tick)
@@ -1117,6 +1121,10 @@ static int perf_mux_hrtimer_restart(struct perf_cpu_context *cpuctx)
if (pmu->task_ctx_nr == perf_sw_context)
return 0;
+ /* No PMU support */
+ if (pmu->capabilities & PERF_PMU_CAP_NO_MUX_EVENTS)
+ return 0;
+
raw_spin_lock_irqsave(&cpuctx->hrtimer_lock, flags);
if (!cpuctx->hrtimer_active) {
cpuctx->hrtimer_active = 1;
--
2.17.1
next prev parent reply other threads:[~2019-11-06 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 1:01 [PATCH 0/2] Workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` Ganapatrao Prabhakerrao Kulkarni [this message]
2019-11-06 9:40 ` [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing Peter Zijlstra
2019-11-06 9:58 ` Peter Zijlstra
2019-11-06 11:28 ` Mark Rutland
2019-11-06 23:28 ` Ganapatrao Kulkarni
2019-11-07 14:35 ` Ganapatrao Kulkarni
2019-11-07 14:52 ` Mark Rutland
2019-11-07 15:45 ` Ganapatrao Kulkarni
2019-11-07 15:54 ` Mark Rutland
2019-11-07 15:04 ` Peter Zijlstra
2019-11-07 23:17 ` kbuild test robot
2019-11-06 1:01 ` [PATCH 2/2] Thunderx2, uncore: Add workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 11:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573002091-9744-2-git-send-email-gkulkarni@marvell.com \
--to=gkulkarni@marvell.com \
--cc=corbet@lwn.net \
--cc=gklkml16@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®