From: yu kuai <yukuai3@huawei.com>
To: <alexander.deucher@amd.com>, <Felix.Kuehling@amd.com>,
<christian.koenig@amd.com>, <David1.Zhou@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <Rex.Zhu@amd.com>,
<evan.quan@amd.com>
Cc: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<amd-gfx@lists.freedesktop.org>, <yukuai3@huawei.com>,
<zhengbin13@huawei.com>, <yi.zhang@huawei.com>
Subject: [PATCH 7/7] drm/amd/powerplay: remove set but not used variable 'us_mvdd'
Date: Wed, 13 Nov 2019 20:44:34 +0800 [thread overview]
Message-ID: <1573649074-72589-8-git-send-email-yukuai3@huawei.com> (raw)
In-Reply-To: <1573649074-72589-1-git-send-email-yukuai3@huawei.com>
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c: In
function ‘vegam_populate_smc_acpi_level’:
drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c:1117:11:
warning: variable 'us_mvdd' set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Fixes: ac7822b0026f ("drm/amd/powerplay: add smumgr support for VEGAM (v2)")
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
index ae18fbc..2068eb0 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
@@ -1114,7 +1114,6 @@ static int vegam_populate_smc_acpi_level(struct pp_hwmgr *hwmgr,
(struct phm_ppt_v1_information *)(hwmgr->pptable);
SMIO_Pattern vol_level;
uint32_t mvdd;
- uint16_t us_mvdd;
table->ACPILevel.Flags &= ~PPSMC_SWSTATE_FLAG_DC;
@@ -1168,17 +1167,6 @@ static int vegam_populate_smc_acpi_level(struct pp_hwmgr *hwmgr,
"in Clock Dependency Table",
);
- us_mvdd = 0;
- if ((SMU7_VOLTAGE_CONTROL_NONE == data->mvdd_control) ||
- (data->mclk_dpm_key_disabled))
- us_mvdd = data->vbios_boot_state.mvdd_bootup_value;
- else {
- if (!vegam_populate_mvdd_value(hwmgr,
- data->dpm_table.mclk_table.dpm_levels[0].value,
- &vol_level))
- us_mvdd = vol_level.Voltage;
- }
-
if (!vegam_populate_mvdd_value(hwmgr, 0, &vol_level))
table->MemoryACPILevel.MinMvdd = PP_HOST_TO_SMC_UL(vol_level.Voltage);
else
--
2.7.4
next prev parent reply other threads:[~2019-11-13 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:44 [PATCH 0/7] various '-Wunused-but-set-variable' gcc warning fixes yu kuai
2019-11-13 12:44 ` [PATCH 1/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' from 'gfx_v6_0.c' and 'gfx_v7_0.c' yu kuai
2019-11-13 16:55 ` Joe Perches
2019-11-13 19:22 ` Alex Deucher
2019-11-13 12:44 ` [PATCH 2/7] drm/amdgpu: remove set but not used variable 'amdgpu_connector' yu kuai
2019-11-13 12:44 ` [PATCH 3/7] drm/amdgpu: remove set but not used variable 'count' yu kuai
2019-11-13 12:44 ` [PATCH 4/7] drm/amdgpu: remove set but not used variable 'invalid' yu kuai
2019-11-13 12:44 ` [PATCH 5/7] drm/amd/powerplay: remove set but not used variable 'threshold' yu kuai
2019-11-13 12:44 ` [PATCH 6/7] drm/amd/powerplay: remove set but not used variable 'state' yu kuai
2019-11-13 12:44 ` yu kuai [this message]
2019-11-13 15:24 ` [PATCH 0/7] various '-Wunused-but-set-variable' gcc warning fixes Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573649074-72589-8-git-send-email-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®