mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: yu kuai <yukuai3@huawei.com>,
	alexander.deucher@amd.com, Felix.Kuehling@amd.com,
	christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie,
	daniel@ffwll.ch, Rex.Zhu@amd.com, evan.quan@amd.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, zhengbin13@huawei.com,
	yi.zhang@huawei.com
Subject: Re: [PATCH 1/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' from 'gfx_v6_0.c' and 'gfx_v7_0.c'
Date: Wed, 13 Nov 2019 08:55:47 -0800	[thread overview]
Message-ID: <ac4566662a04e0c25039df7ed30789d0792885cd.camel@perches.com> (raw)
In-Reply-To: <1573649074-72589-2-git-send-email-yukuai3@huawei.com>

On Wed, 2019-11-13 at 20:44 +0800, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c: In function
> ‘gfx_v6_0_constants_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1579:6: warning: variable
> ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable]
[]
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
[]
> @@ -1678,7 +1678,6 @@ static void gfx_v6_0_constants_init(struct amdgpu_device *adev)
>  
>  	WREG32(mmBIF_FB_EN, BIF_FB_EN__FB_READ_EN_MASK | BIF_FB_EN__FB_WRITE_EN_MASK);
>  
> -	mc_shared_chmap = RREG32(mmMC_SHARED_CHMAP);

I do not know the hardware but frequently hardware like
this has read ordering requirements and various registers
can not be read in a random order.

Does removing this read have no effect on the hardware?

>  	adev->gfx.config.mc_arb_ramcfg = RREG32(mmMC_ARB_RAMCFG);
>  	mc_arb_ramcfg = adev->gfx.config.mc_arb_ramcfg;
>  
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
[]
> @@ -4336,7 +4336,6 @@ static void gfx_v7_0_gpu_early_init(struct amdgpu_device *adev)
>  		break;
>  	}
>  
> -	mc_shared_chmap = RREG32(mmMC_SHARED_CHMAP);
>  	adev->gfx.config.mc_arb_ramcfg = RREG32(mmMC_ARB_RAMCFG);
>  	mc_arb_ramcfg = adev->gfx.config.mc_arb_ramcfg;

Same question.


  reply	other threads:[~2019-11-13 16:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 12:44 [PATCH 0/7] various '-Wunused-but-set-variable' gcc warning fixes yu kuai
2019-11-13 12:44 ` [PATCH 1/7] drm/amdgpu: remove set but not used variable 'mc_shared_chmap' from 'gfx_v6_0.c' and 'gfx_v7_0.c' yu kuai
2019-11-13 16:55   ` Joe Perches [this message]
2019-11-13 19:22     ` Alex Deucher
2019-11-13 12:44 ` [PATCH 2/7] drm/amdgpu: remove set but not used variable 'amdgpu_connector' yu kuai
2019-11-13 12:44 ` [PATCH 3/7] drm/amdgpu: remove set but not used variable 'count' yu kuai
2019-11-13 12:44 ` [PATCH 4/7] drm/amdgpu: remove set but not used variable 'invalid' yu kuai
2019-11-13 12:44 ` [PATCH 5/7] drm/amd/powerplay: remove set but not used variable 'threshold' yu kuai
2019-11-13 12:44 ` [PATCH 6/7] drm/amd/powerplay: remove set but not used variable 'state' yu kuai
2019-11-13 12:44 ` [PATCH 7/7] drm/amd/powerplay: remove set but not used variable 'us_mvdd' yu kuai
2019-11-13 15:24 ` [PATCH 0/7] various '-Wunused-but-set-variable' gcc warning fixes Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac4566662a04e0c25039df7ed30789d0792885cd.camel@perches.com \
    --to=joe@perches.com \
    --cc=David1.Zhou@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Rex.Zhu@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®