mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: smem: Fix signedness bug
Date: Tue, 18 Aug 2026 10:38:43 +0200	[thread overview]
Message-ID: <15740cab-8485-4887-96dc-b5895a7d7656@oss.qualcomm.com> (raw)
In-Reply-To: <20260818023441.891274-1-ethantidmore06@gmail.com>

On 8/18/26 4:34 AM, Ethan Tidmore wrote:
> The function smem_dram_infer_struct_version() returns negative error
> codes and 'ver' is an enum, which makes subsequent condition (ver < 0)
> always impossible.
> 
> Fixes: 1d234eeafc56a ("soc: qcom: smem: Expose DDR data from SMEM")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---

We already got another fix for that:

https://lore.kernel.org/linux-arm-msm/an1toQ-acGR0kOWj@stanley.mountain/

Konrad

      reply	other threads:[~2026-08-18  8:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  2:34 Ethan Tidmore
2026-08-18  8:38 ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15740cab-8485-4887-96dc-b5895a7d7656@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=ethantidmore06@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®