From: Roger Quadros <rogerq@ti.com>
To: <balbi@kernel.org>
Cc: <Peter.Chen@nxp.com>, <gregkh@linuxfoundation.org>,
<garsilva@embeddedor.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"#v4 . 8+" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()
Date: Thu, 9 Mar 2017 09:17:00 +0200 [thread overview]
Message-ID: <157a2d6f-1d0a-b9f3-c1ea-cee90877e580@ti.com> (raw)
In-Reply-To: <1487158704-9006-2-git-send-email-rogerq@ti.com>
Felipe,
On 15/02/17 13:38, Roger Quadros wrote:
> We need to break from all cases if we want to treat
> each one of them separately.
>
> Reported-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
> Cc: <stable@vger.kernel.org> #v4.8+
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Can you please pick this one for v4.11-rc? Thanks.
> ---
> drivers/usb/dwc3/dwc3-omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index eb1b9cb..35b6351 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap,
> val = dwc3_omap_read_utmi_ctrl(omap);
> val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG;
> dwc3_omap_write_utmi_ctrl(omap, val);
> + break;
>
> case OMAP_DWC3_VBUS_OFF:
> val = dwc3_omap_read_utmi_ctrl(omap);
>
--
cheers,
-roger
next prev parent reply other threads:[~2017-03-09 7:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 11:38 [PATCH 0/3] usb: dwc3: trivial fixes Roger Quadros
2017-02-15 11:38 ` [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() Roger Quadros
2017-03-09 7:17 ` Roger Quadros [this message]
2017-02-15 11:38 ` [PATCH 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros
2017-02-15 11:44 ` Felipe Balbi
2017-02-15 15:25 ` Roger Quadros
2017-02-16 8:54 ` Felipe Balbi
2017-02-16 10:33 ` Roger Quadros
2017-02-16 11:08 ` [PATCH v2 " Roger Quadros
2017-03-10 11:31 ` Felipe Balbi
2017-02-15 11:38 ` [PATCH 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157a2d6f-1d0a-b9f3-c1ea-cee90877e580@ti.com \
--to=rogerq@ti.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®