* [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
@ 2020-02-06 8:21 Can Guo
2020-02-06 13:21 ` Avri Altman
2020-02-20 6:20 ` Avri Altman
0 siblings, 2 replies; 4+ messages in thread
From: Can Guo @ 2020-02-06 8:21 UTC (permalink / raw)
To: asutoshd, nguyenb, hongwus, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn, cang
Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Thomas Gleixner, Bean Huo, Stanley Chu,
Bart Van Assche, Venkat Gopalakrishnan, Tomas Winkler, open list
Western Digital UFS devices require host PA_TACTIVATE to be lower than
device PA_TACTIVATE, otherwise it may get stuck during hibern8 sequence.
Signed-off-by: Can Guo <cang@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.h
index d0ab147..df7a1e6 100644
--- a/drivers/scsi/ufs/ufs_quirks.h
+++ b/drivers/scsi/ufs/ufs_quirks.h
@@ -15,6 +15,7 @@
#define UFS_VENDOR_TOSHIBA 0x198
#define UFS_VENDOR_SAMSUNG 0x1CE
#define UFS_VENDOR_SKHYNIX 0x1AD
+#define UFS_VENDOR_WDC 0x145
/**
* ufs_dev_fix - ufs device quirk info
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1fe0a97..a066f00 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = {
UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),
UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1" /*H28U62301AMR*/,
UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME),
+ UFS_FIX(UFS_VENDOR_WDC, UFS_ANY_MODEL,
+ UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
END_FIX
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
2020-02-06 8:21 [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices Can Guo
@ 2020-02-06 13:21 ` Avri Altman
2020-02-20 6:20 ` Avri Altman
1 sibling, 0 replies; 4+ messages in thread
From: Avri Altman @ 2020-02-06 13:21 UTC (permalink / raw)
To: Can Guo, asutoshd, nguyenb, hongwus, rnayak, linux-scsi,
kernel-team, saravanak, salyzyn
Cc: Alim Akhtar, James E.J. Bottomley, Martin K. Petersen,
Thomas Gleixner, Bean Huo, Stanley Chu, Bart Van Assche,
Venkat Gopalakrishnan, Tomas Winkler, open list
Hi,
>
> Western Digital UFS devices require host PA_TACTIVATE to be lower than
> device PA_TACTIVATE, otherwise it may get stuck during hibern8 sequence.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
Please allow few more days to consult internally about this.
Thanks,
Avri
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
2020-02-06 8:21 [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices Can Guo
2020-02-06 13:21 ` Avri Altman
@ 2020-02-20 6:20 ` Avri Altman
2020-02-20 6:34 ` Can Guo
1 sibling, 1 reply; 4+ messages in thread
From: Avri Altman @ 2020-02-20 6:20 UTC (permalink / raw)
To: Can Guo, asutoshd, nguyenb, hongwus, rnayak, linux-scsi,
kernel-team, saravanak, salyzyn
Cc: Alim Akhtar, James E.J. Bottomley, Martin K. Petersen,
Thomas Gleixner, Bean Huo, Stanley Chu, Bart Van Assche,
Venkat Gopalakrishnan, Tomas Winkler, open list
Hi,
>
> /**
> * ufs_dev_fix - ufs device quirk info
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 1fe0a97..a066f00 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = {
> UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),
> UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1" /*H28U62301AMR*/,
> UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME),
> + UFS_FIX(UFS_VENDOR_WDC, UFS_ANY_MODEL,
> + UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
We are objecting to apply this quirk categorically for all SOC vendors.
Please use a vendor-specific quirk for that.
Thanks,
Avri
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
2020-02-20 6:20 ` Avri Altman
@ 2020-02-20 6:34 ` Can Guo
0 siblings, 0 replies; 4+ messages in thread
From: Can Guo @ 2020-02-20 6:34 UTC (permalink / raw)
To: Avri Altman
Cc: asutoshd, nguyenb, hongwus, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn, Alim Akhtar, James E.J. Bottomley,
Martin K. Petersen, Thomas Gleixner, Bean Huo, Stanley Chu,
Bart Van Assche, Venkat Gopalakrishnan, Tomas Winkler, open list
On 2020-02-20 14:20, Avri Altman wrote:
> Hi,
>
>>
>> /**
>> * ufs_dev_fix - ufs device quirk info
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 1fe0a97..a066f00 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = {
>> UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),
>> UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1" /*H28U62301AMR*/,
>> UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME),
>> + UFS_FIX(UFS_VENDOR_WDC, UFS_ANY_MODEL,
>> + UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
> We are objecting to apply this quirk categorically for all SOC vendors.
> Please use a vendor-specific quirk for that.
>
> Thanks,
> Avri
Yeah, as we discussed, I will apply it in ufshcd_vops_apply_dev_quirks()
in next version and this is agreed by Stanley as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-20 6:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 8:21 [PATCH] scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices Can Guo
2020-02-06 13:21 ` Avri Altman
2020-02-20 6:20 ` Avri Altman
2020-02-20 6:34 ` Can Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome