* [PATCH] extcon: Mark extcon_get_edev_name() function as exported symbol @ 2020-03-16 20:14 ` Mayank Rana 2020-03-18 8:30 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Mayank Rana @ 2020-03-16 20:14 UTC (permalink / raw) To: myungjoo.ham, cw00.choi; +Cc: Mayank Rana, linux-kernel, jackp extcon_get_edev_name() function provides client driver to request extcon dev's name. If extcon driver and client driver are compiled as loadable modules, extcon_get_edev_name() function symbol is not visible to client driver. Hence mark extcon_find_edev_name() function as exported symbol. Signed-off-by: Mayank Rana <mrana@codeaurora.org> --- drivers/extcon/extcon.c | 1 + include/linux/extcon.h | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index e055893..2dfbfec 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1406,6 +1406,7 @@ const char *extcon_get_edev_name(struct extcon_dev *edev) { return !edev ? NULL : edev->name; } +EXPORT_SYMBOL_GPL(extcon_get_edev_name); static int __init extcon_class_init(void) { diff --git a/include/linux/extcon.h b/include/linux/extcon.h index 1b1d77e..fd183fb 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -286,6 +286,11 @@ static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, { return ERR_PTR(-ENODEV); } + +static inline const char *extcon_get_edev_name(struct extcon_dev *edev) +{ + return NULL; +} #endif /* CONFIG_EXTCON */ /* -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: Mark extcon_get_edev_name() function as exported symbol 2020-03-16 20:14 ` [PATCH] extcon: Mark extcon_get_edev_name() function as exported symbol Mayank Rana @ 2020-03-18 8:30 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2020-03-18 8:30 UTC (permalink / raw) To: Mayank Rana, myungjoo.ham; +Cc: linux-kernel, jackp On 3/17/20 5:14 AM, Mayank Rana wrote: > extcon_get_edev_name() function provides client driver to request > extcon dev's name. If extcon driver and client driver are compiled > as loadable modules, extcon_get_edev_name() function symbol is not > visible to client driver. Hence mark extcon_find_edev_name() function > as exported symbol. > > Signed-off-by: Mayank Rana <mrana@codeaurora.org> > --- > drivers/extcon/extcon.c | 1 + > include/linux/extcon.h | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index e055893..2dfbfec 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -1406,6 +1406,7 @@ const char *extcon_get_edev_name(struct extcon_dev *edev) > { > return !edev ? NULL : edev->name; > } > +EXPORT_SYMBOL_GPL(extcon_get_edev_name); > > static int __init extcon_class_init(void) > { > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index 1b1d77e..fd183fb 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -286,6 +286,11 @@ static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, > { > return ERR_PTR(-ENODEV); > } > + > +static inline const char *extcon_get_edev_name(struct extcon_dev *edev) > +{ > + return NULL; > +} > #endif /* CONFIG_EXTCON */ > > /* > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-18 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200316201450epcas1p3a20b0db35d64af8f50925079ca5fabf6@epcas1p3.samsung.com>
2020-03-16 20:14 ` [PATCH] extcon: Mark extcon_get_edev_name() function as exported symbol Mayank Rana
2020-03-18 8:30 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome