* [PATCH] pinctrl: sunxi: handle probe defferal
@ 2020-04-02 9:08 Corentin Labbe
2020-04-02 11:32 ` Maxime Ripard
2020-04-16 8:23 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Corentin Labbe @ 2020-04-02 9:08 UTC (permalink / raw)
To: linus.walleij, mripard, wens
Cc: linux-arm-kernel, linux-gpio, linux-kernel, linux-sunxi, Corentin Labbe
When checking the logs on my sun8i-a33-olinuxino I saw:
sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing
but this driver was working after.
This message is just here because the reset controller was still not probed.
So don't say anything if the return code say to wait.
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
index 8a08c4afc6a8..9e5b61449999 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
@@ -103,8 +103,11 @@ static int sun8i_a23_r_pinctrl_probe(struct platform_device *pdev)
rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rstc)) {
- dev_err(&pdev->dev, "Reset controller missing\n");
- return PTR_ERR(rstc);
+ ret = PTR_ERR(rstc);
+ if (ret == -EPROBE_DEFER)
+ return ret;
+ dev_err(&pdev->dev, "Reset controller missing err=%d\n", ret);
+ return ret;
}
ret = reset_control_deassert(rstc);
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: sunxi: handle probe defferal
2020-04-02 9:08 [PATCH] pinctrl: sunxi: handle probe defferal Corentin Labbe
@ 2020-04-02 11:32 ` Maxime Ripard
2020-04-16 8:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-04-02 11:32 UTC (permalink / raw)
To: Corentin Labbe
Cc: linus.walleij, wens, linux-arm-kernel, linux-gpio, linux-kernel,
linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Thu, Apr 02, 2020 at 09:08:52AM +0000, Corentin Labbe wrote:
> When checking the logs on my sun8i-a33-olinuxino I saw:
> sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing
> but this driver was working after.
> This message is just here because the reset controller was still not probed.
> So don't say anything if the return code say to wait.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: sunxi: handle probe defferal
2020-04-02 9:08 [PATCH] pinctrl: sunxi: handle probe defferal Corentin Labbe
2020-04-02 11:32 ` Maxime Ripard
@ 2020-04-16 8:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-04-16 8:23 UTC (permalink / raw)
To: Corentin Labbe
Cc: Maxime Ripard, Chen-Yu Tsai, Linux ARM, open list:GPIO SUBSYSTEM,
linux-kernel, linux-sunxi
On Thu, Apr 2, 2020 at 11:09 AM Corentin Labbe <clabbe@baylibre.com> wrote:
> When checking the logs on my sun8i-a33-olinuxino I saw:
> sun8i-a23-r-pinctrl 1f02c00.pinctrl: Reset controller missing
> but this driver was working after.
> This message is just here because the reset controller was still not probed.
> So don't say anything if the return code say to wait.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Patch applied with Maxime's ACK!
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 9:08 [PATCH] pinctrl: sunxi: handle probe defferal Corentin Labbe
2020-04-02 11:32 ` Maxime Ripard
2020-04-16 8:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®