From: Li Bin <huawei.libin@huawei.com>
To: <dgilbert@interlog.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<huawei.libin@huawei.com>, <xiexiuqi@huawei.com>
Subject: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
Date: Mon, 13 Apr 2020 19:32:32 +0800 [thread overview]
Message-ID: <1586777552-17524-1-git-send-email-huawei.libin@huawei.com> (raw)
Fix a memory leak when there have failed, that we should free the pages
under the condition rem_sz > 0.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
drivers/scsi/sg.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 4e6af592..8441ac5 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1959,8 +1959,12 @@ static long sg_compat_ioctl(struct file *filp, unsigned int cmd_in, unsigned lon
k, rem_sz));
schp->bufflen = blk_size;
- if (rem_sz > 0) /* must have failed */
+ if (rem_sz > 0) { /* must have failed */
+ for (i = 0; i < k; i++)
+ __free_pages(schp->pages[i], order);
+
return -ENOMEM;
+ }
return 0;
out:
for (i = 0; i < k; i++)
--
1.7.12.4
next reply other threads:[~2020-04-13 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 11:32 Li Bin [this message]
2020-04-13 22:15 ` Douglas Gilbert
2020-04-13 19:35 Markus Elfring
2020-04-14 1:39 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586777552-17524-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome