From: Markus Elfring <Markus.Elfring@web.de>
To: Li Bin <huawei.libin@huawei.com>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Doug Gilbert <dgilbert@interlog.com>,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Xie XiuQi <xiexiuqi@huawei.com>
Subject: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
Date: Mon, 13 Apr 2020 21:35:43 +0200 [thread overview]
Message-ID: <8b5551e6-46e2-9def-8ab6-ec5ba252c5ea@web.de> (raw)
> Fix a memory leak when there have failed, that we should free the pages
> under the condition rem_sz > 0.
I suggest to improve the change description.
* Please use an imperative wording.
* Will the tag “Fixes” become relevant?
Regards,
Markus
next reply other threads:[~2020-04-13 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 19:35 Markus Elfring [this message]
2020-04-14 1:39 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2020-04-13 11:32 Li Bin
2020-04-13 22:15 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b5551e6-46e2-9def-8ab6-ec5ba252c5ea@web.de \
--to=markus.elfring@web.de \
--cc=dgilbert@interlog.com \
--cc=huawei.libin@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®