* [tip: objtool/core] objtool: Remove redundant .rodata section name comparison
@ 2020-04-23 7:49 tip-bot2 for Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Muchun Song @ 2020-04-23 7:49 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Muchun Song, Josh Poimboeuf, Ingo Molnar, x86, LKML
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: 1ee444700e960b017558038a9443474e808b0045
Gitweb: https://git.kernel.org/tip/1ee444700e960b017558038a9443474e808b0045
Author: Muchun Song <songmuchun@bytedance.com>
AuthorDate: Sun, 12 Apr 2020 22:44:05 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 22 Apr 2020 10:53:50 +02:00
objtool: Remove redundant .rodata section name comparison
If the prefix of section name is not '.rodata', the following
function call can never return 0.
strcmp(sec->name, C_JUMP_TABLE_SECTION)
So the name comparison is pointless, just remove it.
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/check.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index cffa5e3..e06a891 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1354,8 +1354,8 @@ static void mark_rodata(struct objtool_file *file)
* .rodata.str1.* sections are ignored; they don't contain jump tables.
*/
for_each_sec(file, sec) {
- if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) ||
- !strcmp(sec->name, C_JUMP_TABLE_SECTION)) {
+ if (!strncmp(sec->name, ".rodata", 7) &&
+ !strstr(sec->name, ".str1.")) {
sec->rodata = true;
found = true;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: objtool/core] objtool: Remove redundant .rodata section name comparison
@ 2020-04-22 22:24 tip-bot2 for Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Muchun Song @ 2020-04-22 22:24 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Muchun Song, Josh Poimboeuf, x86, LKML
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: 069cdb3f72e947c7564240fa4c5468b7e514b679
Gitweb: https://git.kernel.org/tip/069cdb3f72e947c7564240fa4c5468b7e514b679
Author: Muchun Song <songmuchun@bytedance.com>
AuthorDate: Sun, 12 Apr 2020 22:44:05 +08:00
Committer: Josh Poimboeuf <jpoimboe@redhat.com>
CommitterDate: Tue, 14 Apr 2020 17:34:07 -05:00
objtool: Remove redundant .rodata section name comparison
If the prefix of section name is not '.rodata', the following
function call can never return 0.
strcmp(sec->name, C_JUMP_TABLE_SECTION)
So the name comparison is pointless, just remove it.
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/check.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 10fbfb3..276bce3 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1372,8 +1372,8 @@ static void mark_rodata(struct objtool_file *file)
* .rodata.str1.* sections are ignored; they don't contain jump tables.
*/
for_each_sec(file, sec) {
- if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) ||
- !strcmp(sec->name, C_JUMP_TABLE_SECTION)) {
+ if (!strncmp(sec->name, ".rodata", 7) &&
+ !strstr(sec->name, ".str1.")) {
sec->rodata = true;
found = true;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-23 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 7:49 [tip: objtool/core] objtool: Remove redundant .rodata section name comparison tip-bot2 for Muchun Song
-- strict thread matches above, loose matches on Subject: below --
2020-04-22 22:24 tip-bot2 for Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®