[PATCH] regulator: da9063: fix LDO9 suspend and warning.

[PATCH] regulator: da9063: fix LDO9 suspend and warning.

[Martin Fuzzey]

Commit 99f75ce66619 ("regulator: da9063: fix suspend") converted
the regulators to use a common (corrected) suspend bit setting but
one of regulators (LDO9) slipped through the crack.


This means that the original problem was not fixed for LDO9 and
also leads to a warning found by the test robot.
	da9063-regulator.c:515:3: warning: initialized field overwritten

Fix this by converting that regulator too like the others.


Fixes: 99f75ce66619 ("regulator: da9063: fix suspend")
Reported-by: kernel test robot <lkp@intel.com>

Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
---
 drivers/regulator/da9063-regulator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index e1d6c8f..fe65b5ac 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -512,7 +512,6 @@ static int da9063_ldo_set_suspend_mode(struct regulator_dev *rdev,
 	},
 	{
 		DA9063_LDO(DA9063, LDO9, 950, 50, 3600),
-		.suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
 	},
 	{
 		DA9063_LDO(DA9063, LDO11, 900, 50, 3600),
-- 
1.9.1

Re: [PATCH] regulator: da9063: fix LDO9 suspend and warning.

[Mark Brown]

On Fri, 12 Jun 2020 12:50:33 +0200, Martin Fuzzey wrote:
> Commit 99f75ce66619 ("regulator: da9063: fix suspend") converted
> the regulators to use a common (corrected) suspend bit setting but
> one of regulators (LDO9) slipped through the crack.
> 
> 
> This means that the original problem was not fixed for LDO9 and
> also leads to a warning found by the test robot.
> 	da9063-regulator.c:515:3: warning: initialized field overwritten
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: da9063: fix LDO9 suspend and warning.
      commit: d7442ba13d62de9afc4e57344a676f9f4623dcaa

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark