mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] cifs: Remove the superfluous break
@ 2020-07-14 10:59 Yi Wang
  2020-07-15  4:19 ` Steve French
  0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-07-14 10:59 UTC (permalink / raw)
  To: sfrench
  Cc: linux-cifs, samba-technical, linux-kernel, xue.zhihong,
	wang.yi59, wang.liang82, Liao Pingfang

From: Liao Pingfang <liao.pingfang@zte.com.cn>

Remove the superfuous break, as there is a 'return' before it.

Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
 fs/cifs/sess.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index 5d05bd2..6708ab0 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -1705,7 +1705,6 @@ static int select_sec(struct cifs_ses *ses, struct sess_data *sess_data)
 #else
 		cifs_dbg(VFS, "Kerberos negotiated but upcall support disabled!\n");
 		return -ENOSYS;
-		break;
 #endif /* CONFIG_CIFS_UPCALL */
 	case RawNTLMSSP:
 		sess_data->func = sess_auth_rawntlmssp_negotiate;
-- 
2.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cifs: Remove the superfluous break
  2020-07-14 10:59 [PATCH] cifs: Remove the superfluous break Yi Wang
@ 2020-07-15  4:19 ` Steve French
  0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2020-07-15  4:19 UTC (permalink / raw)
  To: Yi Wang
  Cc: Steve French, CIFS, samba-technical, LKML, xue.zhihong,
	wang.liang82, Liao Pingfang

merged into cifs-2.6.git for-next

thx

On Tue, Jul 14, 2020 at 6:14 AM Yi Wang <wang.yi59@zte.com.cn> wrote:
>
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove the superfuous break, as there is a 'return' before it.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
>  fs/cifs/sess.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
> index 5d05bd2..6708ab0 100644
> --- a/fs/cifs/sess.c
> +++ b/fs/cifs/sess.c
> @@ -1705,7 +1705,6 @@ static int select_sec(struct cifs_ses *ses, struct sess_data *sess_data)
>  #else
>                 cifs_dbg(VFS, "Kerberos negotiated but upcall support disabled!\n");
>                 return -ENOSYS;
> -               break;
>  #endif /* CONFIG_CIFS_UPCALL */
>         case RawNTLMSSP:
>                 sess_data->func = sess_auth_rawntlmssp_negotiate;
> --
> 2.9.5
>


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-15  4:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 10:59 [PATCH] cifs: Remove the superfluous break Yi Wang
2020-07-15  4:19 ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®