From: Chase Metzger <chasemetzger15@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Chase Metzger <chasemetzger15@gmail.com>,
Marcus Wolf <linux@Wolf-Entwicklungen.de>,
Joseph Wright <rjosephwright@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Al Viro <viro@zeniv.linux.org.uk>,
Xiangyang Zhang <xyz.sun.ok@gmail.com>,
Srishti Sharma <srishtishar@gmail.com>,
Derek Robson <robsonde@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] staging: pi433: pi433_if.c: fix trailing statement coding style issues
Date: Wed, 15 Nov 2017 16:35:50 -0800 [thread overview]
Message-ID: <1597853773c53a166a657ff006cb1e4cc8d4d792.1510790802.git.chasemetzger15@gmail.com> (raw)
In-Reply-To: <cover.1510790802.git.chasemetzger15@gmail.com>
In-Reply-To: <cover.1510790802.git.chasemetzger15@gmail.com>
Put trailing statement after if/else statements on new line to comply
with the kernel coding style.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 44 +++++++++++++++++++++++++++-------------
1 file changed, 30 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index cd1430a04928..3c5d8a05e976 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -156,8 +156,10 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
if (device->irq_state[DIO1] == DIO_FifoNotEmpty_DIO1) {
device->free_in_fifo = FIFO_SIZE;
} else if (device->irq_state[DIO1] == DIO_FifoLevel) {
- if (device->rx_active) device->free_in_fifo = FIFO_THRESHOLD - 1;
- else device->free_in_fifo = FIFO_SIZE - FIFO_THRESHOLD - 1;
+ if (device->rx_active)
+ device->free_in_fifo = FIFO_THRESHOLD - 1;
+ else
+ device->free_in_fifo = FIFO_SIZE - FIFO_THRESHOLD - 1;
}
dev_dbg(device->dev,
"DIO1 irq: %d bytes free in fifo\n", device->free_in_fifo);
@@ -213,8 +215,10 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg)
SET_CHECKED(rf69_set_payload_length(dev->spi, 0xff));
} else if (rx_cfg->fixed_message_length != 0) {
payload_length = rx_cfg->fixed_message_length;
- if (rx_cfg->enable_length_byte == optionOn) payload_length++;
- if (rx_cfg->enable_address_filtering != filteringOff) payload_length++;
+ if (rx_cfg->enable_length_byte == optionOn)
+ payload_length++;
+ if (rx_cfg->enable_address_filtering != filteringOff)
+ payload_length++;
SET_CHECKED(rf69_set_payload_length(dev->spi, payload_length));
} else {
SET_CHECKED(rf69_set_payload_length(dev->spi, 0));
@@ -285,7 +289,8 @@ pi433_start_rx(struct pi433_device *dev)
/* setup for receiving */
retval = rf69_set_rx_cfg(dev, &dev->rx_cfg);
- if (retval) return retval;
+ if (retval)
+ return retval;
/* setup rssi irq */
SET_CHECKED(rf69_set_dio_mapping(dev->spi, DIO0, DIO_Rssi_DIO0));
@@ -347,11 +352,13 @@ pi433_receive(void *data)
retval = wait_event_interruptible(dev->rx_wait_queue,
rf69_get_flag(dev->spi,
rssiExceededThreshold));
- if (retval) goto abort; /* wait was interrupted */
+ if (retval) /* wait was interrupted */
+ goto abort;
dev->interrupt_rx_allowed = false;
/* cross check for ongoing tx */
- if (!dev->tx_active) break;
+ if (!dev->tx_active)
+ break;
}
/* configure payload ready irq */
@@ -376,7 +383,8 @@ pi433_receive(void *data)
if (dev->rx_cfg.enable_length_byte == optionOn) {
retval = wait_event_interruptible(dev->fifo_wait_queue,
dev->free_in_fifo < FIFO_SIZE);
- if (retval) goto abort; /* wait was interrupted */
+ if (retval) /* wait was interrupted */
+ goto abort;
rf69_read_fifo(spi, (u8 *)&bytes_total, 1);
if (bytes_total > dev->rx_buffer_size) {
@@ -395,7 +403,8 @@ pi433_receive(void *data)
retval = wait_event_interruptible(dev->fifo_wait_queue,
dev->free_in_fifo < FIFO_SIZE);
- if (retval) goto abort; /* wait was interrupted */
+ if (retval) /* wait was interrupted */
+ goto abort;
rf69_read_fifo(spi, &dummy, 1);
dev->free_in_fifo++;
@@ -407,7 +416,8 @@ pi433_receive(void *data)
if ( !rf69_get_flag(dev->spi, payloadReady) ) {
retval = wait_event_interruptible(dev->fifo_wait_queue,
dev->free_in_fifo < FIFO_SIZE);
- if (retval) goto abort; /* wait was interrupted */
+ if (retval) /* wait was interrupted */
+ goto abort;
}
/* need to drop bytes or acquire? */
@@ -423,7 +433,8 @@ pi433_receive(void *data)
retval = rf69_read_fifo(spi,
&dev->rx_buffer[dev->rx_position],
bytes_to_read);
- if (retval) goto abort; /* read failed */
+ if (retval) /* read failed */
+ goto abort;
dev->free_in_fifo += bytes_to_read;
/* adjust status vars */
@@ -592,7 +603,10 @@ pi433_tx_thread(void *data)
retval = wait_event_interruptible(device->fifo_wait_queue,
device->free_in_fifo > 0);
- if (retval) { printk("ABORT\n"); goto abort; }
+ if (retval) {
+ printk("ABORT\n");
+ goto abort;
+ }
}
/* we are done. Wait for packet to get sent */
@@ -600,7 +614,8 @@ pi433_tx_thread(void *data)
wait_event_interruptible(device->fifo_wait_queue,
device->free_in_fifo == FIFO_SIZE ||
kthread_should_stop() );
- if ( kthread_should_stop() ) printk("ABORT\n");
+ if ( kthread_should_stop() )
+ printk("ABORT\n");
/* STOP_TRANSMISSION */
@@ -894,7 +909,8 @@ static int setup_GPIOs(struct pi433_device *device)
/* configure the pin */
gpiod_unexport(device->gpiod[i]);
retval = gpiod_direction_input(device->gpiod[i]);
- if (retval) return retval;
+ if (retval)
+ return retval;
/* configure irq */
--
2.11.0
next prev parent reply other threads:[~2017-11-16 0:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 0:35 [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes Chase Metzger
2017-11-16 0:35 ` [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues Chase Metzger
2017-11-28 13:08 ` Greg KH
2017-11-16 0:35 ` [PATCH 2/6] staging: pi433: pi433_if.c: fix else if/else statements " Chase Metzger
2017-11-16 0:35 ` Chase Metzger [this message]
2017-11-16 0:35 ` [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited " Chase Metzger
2017-11-28 13:09 ` Greg KH
2017-11-16 0:35 ` [PATCH 5/6] staging: pi433: pi433_if.c: fix space(s) required " Chase Metzger
2017-11-16 0:35 ` [PATCH 6/6] staging: pi433: pi433_if.c: use tabs instead of spaces Chase Metzger
2017-11-28 13:10 ` [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597853773c53a166a657ff006cb1e4cc8d4d792.1510790802.git.chasemetzger15@gmail.com \
--to=chasemetzger15@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=rjosephwright@gmail.com \
--cc=robsonde@gmail.com \
--cc=srishtishar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xyz.sun.ok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®