From: Greg KH <gregkh@linuxfoundation.org>
To: Chase Metzger <chasemetzger15@gmail.com>
Cc: Marcus Wolf <linux@Wolf-Entwicklungen.de>,
Joseph Wright <rjosephwright@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Cihangir Akturk <cakturk@gmail.com>,
Srishti Sharma <srishtishar@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Derek Robson <robsonde@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues
Date: Tue, 28 Nov 2017 14:08:44 +0100 [thread overview]
Message-ID: <20171128130844.GA31525@kroah.com> (raw)
In-Reply-To: <dc5ee7c1f10a073b601e6aed588f068e51cb3a2a.1510790802.git.chasemetzger15@gmail.com>
On Wed, Nov 15, 2017 at 04:35:48PM -0800, Chase Metzger wrote:
> Put opening curly braces for if/else/else if statements and for/while loops
> on the same line as the statements or loops to comply with the kernel
> coding style.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 110 ++++++++++++++-------------------------
> 1 file changed, 38 insertions(+), 72 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index ff86db1c6cbd..76d70345229a 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -153,12 +153,10 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
> {
> struct pi433_device *device = dev_id;
>
> - if (device->irq_state[DIO1] == DIO_FifoNotEmpty_DIO1)
> - {
> + if (device->irq_state[DIO1] == DIO_FifoNotEmpty_DIO1) {
Again, fix up the space issue here at the same time please.
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-28 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 0:35 [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes Chase Metzger
2017-11-16 0:35 ` [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues Chase Metzger
2017-11-28 13:08 ` Greg KH [this message]
2017-11-16 0:35 ` [PATCH 2/6] staging: pi433: pi433_if.c: fix else if/else statements " Chase Metzger
2017-11-16 0:35 ` [PATCH 3/6] staging: pi433: pi433_if.c: fix trailing statement " Chase Metzger
2017-11-16 0:35 ` [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited " Chase Metzger
2017-11-28 13:09 ` Greg KH
2017-11-16 0:35 ` [PATCH 5/6] staging: pi433: pi433_if.c: fix space(s) required " Chase Metzger
2017-11-16 0:35 ` [PATCH 6/6] staging: pi433: pi433_if.c: use tabs instead of spaces Chase Metzger
2017-11-28 13:10 ` [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128130844.GA31525@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cakturk@gmail.com \
--cc=chasemetzger15@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=rjosephwright@gmail.com \
--cc=robsonde@gmail.com \
--cc=srishtishar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®