[PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error

[PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error

[Sang Min Kim]

 
Modify mask value for the temp_error in the sanitize_temp_error() function.
 
Fixes: aef27b658b43 ("thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()")
masked temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff) value even in the case
of EXYNOS7.
In addition, when entering the if statement, both temp_error1 and 2 are
masked with EXYNOS_TMU_TEMP_MASK(0xff).
 
By modifying to use the previously declared local variable tmu_temp_mask,
the mask value suitable for the SOC can be applied.
 
Signed-off-by: sangmin kim <hypmean.kim@samsung.com>
---
 V1 -> V2: Add fixes tag
 
 drivers/thermal/samsung/exynos_tmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index f4ab4c5b4b62..08c63fe5566e 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -243,17 +243,17 @@ static void sanitize_temp_error(struct exynos_tmu_data *data, u32 trim_info)
 
         data->temp_error1 = trim_info & tmu_temp_mask;
         data->temp_error2 = ((trim_info >> EXYNOS_TRIMINFO_85_SHIFT) &
-                                EXYNOS_TMU_TEMP_MASK);
+                                tmu_temp_mask);
 
         if (!data->temp_error1 ||
             (data->min_efuse_value > data->temp_error1) ||
             (data->temp_error1 > data->max_efuse_value))
-                data->temp_error1 = data->efuse_value & EXYNOS_TMU_TEMP_MASK;
+                data->temp_error1 = data->efuse_value & tmu_temp_mask;
 
         if (!data->temp_error2)
                 data->temp_error2 =
                         (data->efuse_value >> EXYNOS_TRIMINFO_85_SHIFT) &
-                        EXYNOS_TMU_TEMP_MASK;
+                        tmu_temp_mask;
 }
 
 static int exynos_tmu_initialize(struct platform_device *pdev)
--
2.9.5

Re: [PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error

[Krzysztof Kozlowski]

On 31/03/2022 09:28, Sang Min Kim wrote:
>  

Unneeded empty line at beginning of msg.

> Modify mask value for the temp_error in the sanitize_temp_error() function.
>  
> Fixes: aef27b658b43 ("thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()")
> masked temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff) value even in the case
> of EXYNOS7.
> In addition, when entering the if statement, both temp_error1 and 2 are
> masked with EXYNOS_TMU_TEMP_MASK(0xff).
>  
> By modifying to use the previously declared local variable tmu_temp_mask,
> the mask value suitable for the SOC can be applied.
>  

Fixes tag goes next to other tags, so usually before Signed-off-by.
Check some existing commits for examples.

> Signed-off-by: sangmin kim <hypmean.kim@samsung.com>

You received by Reviewed-by tag, so you should include it in v2. Don't
skip them.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> ---
>  V1 -> V2: Add fixes tag
>  
>  drivers/thermal/samsung/exynos_tmu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  

Best regards,
Krzysztof