mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"John Harrison" <John.Harrison@igalia.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Tomi Valkeinen" <tomi.valkeinen+renesas@ideasonboard.com>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
	"Mihail Atanassov" <mihail.atanassov@arm.com>,
	"Eric Anholt" <eric@anholt.net>,
	"Rob Clark" <robin.clark@oss.qualcomm.com>,
	"Brian Starkey" <brian.starkey@arm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>
Subject: Re: [PATCH v8 06/10] drm: writeback: rename drm_writeback_connector_init_with_encoder()
Date: Tue, 17 Nov 2026 15:02:22 +0100	[thread overview]
Message-ID: <15c2236a-cd41-4f8d-b6ee-bb56f98f9916@bootlin.com> (raw)
In-Reply-To: <20261111-wb-drop-encoder-v8-6-62948ed87d13@oss.qualcomm.com>



On 11/11/26 01:42, Dmitry Baryshkov wrote:
> Rename drm_writeback_connector_init_with_encoder() to
> drm_writeback_connector_init() and adapt its interface to follow
> drmm_writeback_connector_init(). Drop references to the "custom encoder"
> from the documentation since it's now the only way to specify the
> encoder to the writeback connector.
> 
> Reviewed-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c    | 10 +++++-----
>   .../drm/arm/display/komeda/komeda_wb_connector.c    |  8 ++++----
>   drivers/gpu/drm/arm/malidp_mw.c                     |  8 ++++----
>   drivers/gpu/drm/drm_writeback.c                     | 21 +++++++++------------
>   drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 10 +++++-----
>   drivers/gpu/drm/vc4/vc4_txp.c                       |  8 ++++----
>   include/drm/drm_writeback.h                         | 10 +++++-----
>   7 files changed, 36 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
> index e0ef23f692d4..dde02b2b018b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
> @@ -262,11 +262,11 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display_manager *dm,
>   
>   	drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_funcs);
>   
> -	res = drm_writeback_connector_init_with_encoder(&dm->adev->ddev, &wbcon->base,
> -							&wbcon->encoder,
> -							&amdgpu_dm_wb_connector_funcs,
> -							amdgpu_dm_wb_formats,
> -							ARRAY_SIZE(amdgpu_dm_wb_formats));
> +	res = drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base,
> +					   &amdgpu_dm_wb_connector_funcs,
> +					   &wbcon->encoder,
> +					   amdgpu_dm_wb_formats,
> +					   ARRAY_SIZE(amdgpu_dm_wb_formats));
>   	if (res) {
>   		drm_encoder_cleanup(&wbcon->encoder);
>   		return res;
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 7b795e1c5705..ea4589b00ee0 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -186,10 +186,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
>   		return err;
>   	}
>   
> -	err = drm_writeback_connector_init_with_encoder(&kms->base, wb_conn,
> -							wb_encoder,
> -							&komeda_wb_connector_funcs,
> -							formats, n_formats);
> +	err = drm_writeback_connector_init(&kms->base, wb_conn,
> +					   &komeda_wb_connector_funcs,
> +					   wb_encoder,
> +					   formats, n_formats);
>   	komeda_put_fourcc_list(formats);
>   	if (err) {
>   		drm_encoder_cleanup(wb_encoder);
> diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
> index 889d0d1db85d..3669d10540bf 100644
> --- a/drivers/gpu/drm/arm/malidp_mw.c
> +++ b/drivers/gpu/drm/arm/malidp_mw.c
> @@ -239,10 +239,10 @@ int malidp_mw_connector_init(struct drm_device *drm)
>   		return ret;
>   	}
>   
> -	ret = drm_writeback_connector_init_with_encoder(drm, &malidp->mw_connector,
> -							&malidp->mw_encoder,
> -							&malidp_mw_connector_funcs,
> -							formats, n_formats);
> +	ret = drm_writeback_connector_init(drm, &malidp->mw_connector,
> +					   &malidp_mw_connector_funcs,
> +					   &malidp->mw_encoder,
> +					   formats, n_formats);
>   	kfree(formats);
>   	if (ret) {
>   		drm_encoder_cleanup(&malidp->mw_encoder);
> diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
> index 683da368e339..89c36f1414ce 100644
> --- a/drivers/gpu/drm/drm_writeback.c
> +++ b/drivers/gpu/drm/drm_writeback.c
> @@ -165,8 +165,7 @@ static void delete_writeback_properties(struct drm_device *dev)
>   }
>   
>   /**
> - * __drm_writeback_connector_init - Initialize a writeback connector with
> - * a custom encoder
> + * __drm_writeback_connector_init - Initialize a writeback connector
>    *
>    * @dev: DRM device
>    * @wb_connector: Writeback connector to initialize
> @@ -241,8 +240,7 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
>   }
>   
>   /**
> - * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
> - * a custom encoder
> + * drm_writeback_connector_init - Initialize a writeback connector
>    *
>    * @dev: DRM device
>    * @wb_connector: Writeback connector to initialize
> @@ -269,11 +267,11 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
>    *
>    * Returns: 0 on success, or a negative error code
>    */
> -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> -					      struct drm_writeback_connector *wb_connector,
> -					      struct drm_encoder *enc,
> -					      const struct drm_connector_funcs *con_funcs,
> -					      const u32 *formats, int n_formats)
> +int drm_writeback_connector_init(struct drm_device *dev,
> +				 struct drm_writeback_connector *wb_connector,
> +				 const struct drm_connector_funcs *con_funcs,
> +				 struct drm_encoder *enc,
> +				 const u32 *formats, int n_formats)
>   {
>   	struct drm_connector *connector = &wb_connector->base;
>   	int ret;
> @@ -290,7 +288,7 @@ int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
>   
>   	return ret;
>   }
> -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> +EXPORT_SYMBOL(drm_writeback_connector_init);
>   
>   /**
>    * drm_writeback_connector_cleanup - Cleanup the writeback connector
> @@ -320,8 +318,7 @@ static void drm_writeback_connector_cleanup(struct drm_device *dev,
>   }
>   
>   /**
> - * drmm_writeback_connector_init - Initialize a writeback connector with
> - * a custom encoder
> + * drmm_writeback_connector_init - Initialize a writeback connector
>    *
>    * @dev: DRM device
>    * @wb_connector: Writeback connector to initialize
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c
> index a1271fec9874..a88408124758 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c
> @@ -217,11 +217,11 @@ int rcar_du_writeback_init(struct rcar_du_device *rcdu,
>   	drm_connector_helper_add(&wb_conn->base,
>   				 &rcar_du_wb_conn_helper_funcs);
>   
> -	ret = drm_writeback_connector_init_with_encoder(&rcdu->ddev, wb_conn,
> -							encoder,
> -							&rcar_du_wb_conn_funcs,
> -							writeback_formats,
> -							ARRAY_SIZE(writeback_formats));
> +	ret = drm_writeback_connector_init(&rcdu->ddev, wb_conn,
> +					   &rcar_du_wb_conn_funcs,
> +					   encoder,
> +					   writeback_formats,
> +					   ARRAY_SIZE(writeback_formats));
>   	if (ret)
>   		drm_encoder_cleanup(encoder);
>   
> diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
> index 642953cba25f..6ffc54d23d48 100644
> --- a/drivers/gpu/drm/vc4/vc4_txp.c
> +++ b/drivers/gpu/drm/vc4/vc4_txp.c
> @@ -601,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data)
>   
>   	drm_connector_helper_add(&txp->connector.base,
>   				 &vc4_txp_connector_helper_funcs);
> -	ret = drm_writeback_connector_init_with_encoder(drm, &txp->connector,
> -							encoder,
> -							&vc4_txp_connector_funcs,
> -							drm_fmts, ARRAY_SIZE(drm_fmts));
> +	ret = drm_writeback_connector_init(drm, &txp->connector,
> +					   &vc4_txp_connector_funcs,
> +					   encoder,
> +					   drm_fmts, ARRAY_SIZE(drm_fmts));
>   	if (ret)
>   		return ret;
>   
> diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> index 879ca103320c..958466a05e60 100644
> --- a/include/drm/drm_writeback.h
> +++ b/include/drm/drm_writeback.h
> @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *connector)
>   	return container_of(connector, struct drm_writeback_connector, base);
>   }
>   
> -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> -				struct drm_writeback_connector *wb_connector,
> -				struct drm_encoder *enc,
> -				const struct drm_connector_funcs *con_funcs, const u32 *formats,
> -				int n_formats);
> +int drm_writeback_connector_init(struct drm_device *dev,
> +				 struct drm_writeback_connector *wb_connector,
> +				 const struct drm_connector_funcs *con_funcs,
> +				 struct drm_encoder *enc,
> +				 const u32 *formats, int n_formats);
>   
>   int drmm_writeback_connector_init(struct drm_device *dev,
>   				  struct drm_writeback_connector *wb_connector,
> 


  reply	other threads:[~2026-11-17 14:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  0:42 [PATCH v8 00/10] drm: writeback: clean up writeback connector initialization Dmitry Baryshkov
2026-11-11  0:42 ` [PATCH v8 01/10] drm/amd/display: embed the writeback encoder in amdgpu_dm_wb_connector Dmitry Baryshkov
2026-11-11  0:42 ` [PATCH v8 02/10] drm/komeda: embed the writeback encoder in komeda_wb_connector Dmitry Baryshkov
2026-11-11  0:42 ` [PATCH v8 03/10] drm/mali: embed the writeback encoder in malidp_drm Dmitry Baryshkov
2026-11-11  0:42 ` [PATCH v8 04/10] drm: renesas: rcar-du: embed the writeback encoder in rcar_du_crtc Dmitry Baryshkov
2026-11-16 23:49   ` John Harrison
2026-11-11  0:42 ` [PATCH v8 05/10] drm: writeback: drop excess connector initialization functions Dmitry Baryshkov
2026-11-11  0:42 ` [PATCH v8 06/10] drm: writeback: rename drm_writeback_connector_init_with_encoder() Dmitry Baryshkov
2026-11-17 14:02   ` Louis Chauvet [this message]
2026-11-11  0:42 ` [PATCH v8 07/10] drm: writeback: don't destroy the shared writeback properties Dmitry Baryshkov
2026-11-12  1:32   ` John Harrison
2026-11-11  0:42 ` [PATCH v8 08/10] drm: writeback: clean up writeback jobs outside the job_lock Dmitry Baryshkov
2026-11-12  1:34   ` John Harrison
2026-11-11  0:42 ` [PATCH v8 09/10] drm: writeback: clean up writeback connectors in drm_connector_cleanup() Dmitry Baryshkov
2026-11-12  1:35   ` John Harrison
2026-11-11  0:42 ` [PATCH v8 10/10] drm: writeback: drop the drmm writeback cleanup action Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15c2236a-cd41-4f8d-b6ee-bb56f98f9916@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=John.Harrison@igalia.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=brian.starkey@arm.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=christian.koenig@amd.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=geert+renesas@glider.be \
    --cc=harry.wentland@amd.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=magnus.damm@gmail.com \
    --cc=mcanal@igalia.com \
    --cc=mihail.atanassov@arm.com \
    --cc=mripard@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=tomi.valkeinen+renesas@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®