From: "Christian König" <christian.koenig@amd.com>
To: Arnd Bergmann <arnd@arndb.de>, Baoyou Xie <baoyou.xie@linaro.org>
Cc: <alexander.deucher@amd.com>, <airlied@linux.ie>,
<Qingqing.Wang@amd.com>, <Monk.Liu@amd.com>,
<JinHuiEric.Huang@amd.com>, <Rex.Zhu@amd.com>,
<nils.wallmenius@gmail.com>, <ray.huang@amd.com>,
<Young.Yang@amd.com>, <Flora.Cui@amd.com>, <Jammy.Zhou@amd.com>,
<funfunctor@folklore1984.net>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible
Date: Mon, 19 Sep 2016 09:59:56 +0200 [thread overview]
Message-ID: <15c872e1-8931-68ca-846e-c909e6e3d5af@amd.com> (raw)
In-Reply-To: <2392100.i5YbeLyK7H@wuerfel>
Am 19.09.2016 um 09:34 schrieb Arnd Bergmann:
> On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote:
>> We get a few warnings when building kernel with W=1:
>> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes]
>> ....
>>
>> In fact, these functions are only used in the file in which they are
>> declared and don't need a declaration, but can be made static.
>> So this patch marks these functions with 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>>
> Hi Baoyou,
>
> All your drm/amd patches seem fine to me, but again (as with the nouveau
> driver patches before), I think it would make more sense to consolidate
> them, and do a small number of patches such as
>
> [PATCH 1/3] drm/amdgpu: add missing includes
> [PATCH 2/3] drm/amdgpu: remove unused functions
> [PATCH 3/3] drm/amdgpu: mark symbol static where possible
>
> This is all one big driver,
No it isn't. The different parts are developed by different teams at
AMD, so the splitting them up is rather welcome here.
So please keep your style as it is, at least for the amdgpu driver.
Regards,
Christian.
> and I see no value in splitting it up
> per file within the driver.
>
> Arnd
next prev parent reply other threads:[~2016-09-19 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 7:28 Baoyou Xie
2016-09-19 7:34 ` Arnd Bergmann
2016-09-19 7:59 ` Christian König [this message]
2016-09-19 8:04 ` Arnd Bergmann
2016-09-19 7:43 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15c872e1-8931-68ca-846e-c909e6e3d5af@amd.com \
--to=christian.koenig@amd.com \
--cc=Flora.Cui@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=Monk.Liu@amd.com \
--cc=Qingqing.Wang@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=Young.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=funfunctor@folklore1984.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nils.wallmenius@gmail.com \
--cc=ray.huang@amd.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®