mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: David Woodhouse <dwmw2@infradead.org>, Andi Kleen <ak@linux.intel.com>
Cc: Paul Turner <pjt@google.com>, LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linux-foundation.org>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	tglx@linutronix.de, Kees Cook <keescook@google.com>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Jiri Kosina <jikos@kernel.org>,
	gnomes@lxorguk.ukuu.org.uk, x86@kernel.org, bp@alien8.de,
	rga@amazon.de
Subject: Re: [PATCH] x86/retpoline: Fill return stack buffer on vmexit
Date: Wed, 10 Jan 2018 18:14:04 -0600	[thread overview]
Message-ID: <15e712cc-3bf3-bc85-7ed4-caeba30a26a4@amd.com> (raw)
In-Reply-To: <1515628062.22302.278.camel@infradead.org>

On 1/10/2018 5:47 PM, David Woodhouse wrote:
> On Wed, 2018-01-10 at 22:51 +0000, David Woodhouse wrote:
>> In accordance with the Intel and AMD documentation, we need to overwrite
>> all entries in the RSB on exiting a guest, to prevent malicious branch
>> target predictions from affecting the host kernel. This is needed both
>> for retpoline and for IBRS.
>>
>> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
>> ---
>> Untested in this form although it's a variant on what we've had already.
>> I have an army of machines willing to do my bidding but nested virt
>> is non-trivial and I figure I might as well post it as someone else
>> can probably test it in less than the time it takes me to work out how.
> 
> Now smoke tested with Intel VT-x, but not yet on AMD. Tom, would you be
> able to do that?

Yes, I'll try to get to it as soon as I can, but it might be tomorrow
(morning).

Thanks,
Tom

> 
> 
>> This implements the most pressing of the RSB stuffing documented
>> by dhansen (based our discussions) in https://goo.gl/pXbvBE

  reply	other threads:[~2018-01-11  0:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 22:51 David Woodhouse
2018-01-10 23:22 ` David Lang
2018-01-10 23:32   ` Woodhouse, David
2018-01-10 23:47 ` Tim Chen
2018-01-11  0:04   ` Woodhouse, David
2018-01-11  8:42     ` Peter Zijlstra
2018-01-11  8:49       ` Boris Petkov
2018-01-11  9:07         ` Woodhouse, David
2018-01-11  9:32           ` Peter Zijlstra
2018-01-11  9:47             ` Borislav Petkov
2018-01-11  9:58               ` Peter Zijlstra
2018-01-11  9:58               ` Woodhouse, David
2018-01-10 23:47 ` David Woodhouse
2018-01-11  0:14   ` Tom Lendacky [this message]
2018-01-11  1:04     ` David Woodhouse
2018-01-11  1:12       ` David Woodhouse
2018-01-12  0:34     ` Tom Lendacky
2018-01-11  8:49 ` Peter Zijlstra
2018-01-11 12:10   ` Woodhouse, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15e712cc-3bf3-bc85-7ed4-caeba30a26a4@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linux-foundation.org \
    --cc=jikos@kernel.org \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rga@amazon.de \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®