[PATCH] HID: logitech-dj: add new lightspeed receiver id

[PATCH] HID: logitech-dj: add new lightspeed receiver id

[Lucas Zampieri]

As of logitech lightspeed receiver fw version 04.02.B0009,
HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.

With patch "HID: logitech-dj: add support for the new lightspeed receiver
iteration", the mouse starts to error out with:
  logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
  slot 1
and becomes unusable.

This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.

Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
---
 drivers/hid/hid-logitech-dj.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index a0017b010c34..9f68c0631439 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -1068,6 +1068,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
 		workitem.reports_supported |= STD_KEYBOARD;
 		break;
 	case 0x0f:
+	case 0x11:
 		device_type = "eQUAD Lightspeed 1.2";
 		logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
 		workitem.reports_supported |= STD_KEYBOARD;
-- 
2.34.1

Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

[Benjamin Tissoires]

On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@redhat.com> wrote:
>
> As of logitech lightspeed receiver fw version 04.02.B0009,
> HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
>
> With patch "HID: logitech-dj: add support for the new lightspeed receiver
> iteration", the mouse starts to error out with:
>   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
>   slot 1
> and becomes unusable.
>
> This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.

The patch looks good to me.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Ideally, Nestor, can you confirm this is expected and that we won't
have any bad surprises there?

I think we probably want this to be Cc-ed to stable once it gets
merged (we can add the tag as we merge it).

Cheers,
Benjamin

>
> Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
> ---
>  drivers/hid/hid-logitech-dj.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index a0017b010c34..9f68c0631439 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1068,6 +1068,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
>                 workitem.reports_supported |= STD_KEYBOARD;
>                 break;
>         case 0x0f:
> +       case 0x11:
>                 device_type = "eQUAD Lightspeed 1.2";
>                 logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
>                 workitem.reports_supported |= STD_KEYBOARD;
> --
> 2.34.1
>

Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

[Filipe Laíns]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Wed, 2022-01-26 at 15:47 +0100, Benjamin Tissoires wrote:
> On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@redhat.com> wrote:
> > 
> > As of logitech lightspeed receiver fw version 04.02.B0009,
> > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > 
> > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > iteration", the mouse starts to error out with:
> >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> >   slot 1
> > and becomes unusable.
> > 
> > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> 
> The patch looks good to me.
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> Ideally, Nestor, can you confirm this is expected and that we won't
> have any bad surprises there?
> 
> I think we probably want this to be Cc-ed to stable once it gets
> merged (we can add the tag as we merge it).
> 
> Cheers,
> Benjamin

This is likely a different connection type, so it should probably get its own
case statement, but let's let Nestor confirm :)

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

[Nestor Lopez Casado]

On Wed, Jan 26, 2022 at 3:55 PM Filipe Laíns <lains@riseup.net> wrote:
>
> On Wed, 2022-01-26 at 15:47 +0100, Benjamin Tissoires wrote:
> > On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@redhat.com> wrote:
> > >
> > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > >
> > > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > > iteration", the mouse starts to error out with:
> > >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> > >   slot 1
> > > and becomes unusable.
> > >
> > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> >
> > The patch looks good to me.
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > Ideally, Nestor, can you confirm this is expected and that we won't
> > have any bad surprises there?
Yes, I confirm this matches our specifications, this is an iteration
of Lightspeed 1.2
No objections on my side.

> >
> > I think we probably want this to be Cc-ed to stable once it gets
> > merged (we can add the tag as we merge it).
> >
> > Cheers,
> > Benjamin
>
> This is likely a different connection type, so it should probably get its own
> case statement, but let's let Nestor confirm :)
>
> Cheers,
> Filipe Laíns
best,
-nestor

Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

[Jiri Kosina]

On Tue, 15 Feb 2022, Nestor Lopez Casado wrote:

> > > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > > >
> > > > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > > > iteration", the mouse starts to error out with:
> > > >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> > > >   slot 1
> > > > and becomes unusable.
> > > >
> > > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> > >
> > > The patch looks good to me.
> > >
> > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > >
> > > Ideally, Nestor, can you confirm this is expected and that we won't
> > > have any bad surprises there?
> Yes, I confirm this matches our specifications, this is an iteration
> of Lightspeed 1.2
> No objections on my side.

Thanks. Based on this, I've applied this with

	Acked-by: Nestor Lopez Casado <nlopezcasad@logitech.com>

then. Please shout out loudly if you're not ok with that :)

-- 
Jiri Kosina
SUSE Labs