* [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero
@ 2020-08-26 3:54 YueHaibing
2020-08-26 3:57 ` Lokesh Vutla
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2020-08-26 3:54 UTC (permalink / raw)
To: nm, t-kristo, ssantosh, tglx, jason, maz, lokeshvutla
Cc: linux-arm-kernel, linux-kernel, YueHaibing
ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.
Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/irqchip/irq-ti-sci-inta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e97605456b..05bf94b87b93 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
struct irq_fwspec parent_fwspec;
struct device_node *parent_node;
unsigned int parent_virq;
- u16 vint_id, p_hwirq;
- int ret;
+ int p_hwirq, ret;
+ u16 vint_id;
vint_id = ti_sci_get_free_resource(inta->vint);
if (vint_id == TI_SCI_RESOURCE_NULL)
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero
2020-08-26 3:54 [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero YueHaibing
@ 2020-08-26 3:57 ` Lokesh Vutla
2020-09-13 15:20 ` Marc Zyngier
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: Lokesh Vutla @ 2020-08-26 3:57 UTC (permalink / raw)
To: YueHaibing, nm, t-kristo, ssantosh, tglx, jason, maz
Cc: linux-arm-kernel, linux-kernel
On 26/08/20 9:24 am, YueHaibing wrote:
> ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
>
> Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero
2020-08-26 3:54 [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero YueHaibing
2020-08-26 3:57 ` Lokesh Vutla
@ 2020-09-13 15:20 ` Marc Zyngier
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2020-09-13 15:20 UTC (permalink / raw)
To: Thomas Bogendoerfer, Jason Cooper, Huacai Chen, Thomas Gleixner,
lokeshvutla, t-kristo, nm, ssantosh, YueHaibing
Cc: Huacai Chen, Fuxin Zhang, Jiaxun Yang, linux-mips, linux-kernel,
linux-arm-kernel
On Wed, 26 Aug 2020 11:54:30 +0800, YueHaibing wrote:
> ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
> should be int type.
Applied to irq/irqchip-fixes-5.9, thanks!
[1/1] irqchip/ti-sci-inta: Fix unsigned comparison to zero
commit: 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: irq/core] irqchip/ti-sci-inta: Fix unsigned comparison to zero
2020-08-26 3:54 [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero YueHaibing
2020-08-26 3:57 ` Lokesh Vutla
2020-09-13 15:20 ` Marc Zyngier
@ 2020-10-11 17:57 ` tip-bot2 for YueHaibing
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for YueHaibing @ 2020-10-11 17:57 UTC (permalink / raw)
To: linux-tip-commits; +Cc: YueHaibing, Marc Zyngier, Lokesh Vutla, x86, LKML
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Gitweb: https://git.kernel.org/tip/4c9b1bfaa5039fee650f4de514a8e70ae976fc2f
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Wed, 26 Aug 2020 11:54:30 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 13 Sep 2020 15:30:00 +01:00
irqchip/ti-sci-inta: Fix unsigned comparison to zero
ti_sci_inta_xlate_irq() return -ENOENT on fail, p_hwirq
should be int type.
Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
Link: https://lore.kernel.org/r/20200826035430.21060-1-yuehaibing@huawei.com
---
drivers/irqchip/irq-ti-sci-inta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e9760..05bf94b 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -175,8 +175,8 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
struct irq_fwspec parent_fwspec;
struct device_node *parent_node;
unsigned int parent_virq;
- u16 vint_id, p_hwirq;
- int ret;
+ int p_hwirq, ret;
+ u16 vint_id;
vint_id = ti_sci_get_free_resource(inta->vint);
if (vint_id == TI_SCI_RESOURCE_NULL)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-11 17:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 3:54 [PATCH -next] irqchip/ti-sci-inta: Fix unsigned comparison to zero YueHaibing
2020-08-26 3:57 ` Lokesh Vutla
2020-09-13 15:20 ` Marc Zyngier
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®