* [PATCH] kprobes: Correct a type error in function kprobes_module_callback
@ 2020-10-08 2:59 Zhouyi Zhou
2020-10-08 3:05 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Zhouyi Zhou @ 2020-10-08 2:59 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat, linux-kernel
Cc: Zhouyi Zhou
There is a tiny type error in comment of function kprobes_module_callback.
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
kernel/kprobes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index e995541..9d2042b 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
within_module_core((unsigned long)p->addr, mod))) {
/*
* The vaddr this probe is installed will soon
- * be vfreed buy not synced to disk. Hence,
+ * be vfreed but not synced to disk. Hence,
* disarming the breakpoint isn't needed.
*
* Note, this will also move any optimized probes
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback
2020-10-08 2:59 [PATCH] kprobes: Correct a type error in function kprobes_module_callback Zhouyi Zhou
@ 2020-10-08 3:05 ` Randy Dunlap
2020-10-08 3:08 ` Zhouyi Zhou
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-10-08 3:05 UTC (permalink / raw)
To: Zhouyi Zhou, naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat,
linux-kernel
Hi,
On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> There is a tiny type error in comment of function kprobes_module_callback.
Preferable
typo
and same in $Subject.
'type' usually means data type or maybe typedef, or even
font or typeface.
I suppose you could say a "typing" error (as in using a typewriter
or keyboard).
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index e995541..9d2042b 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> within_module_core((unsigned long)p->addr, mod))) {
> /*
> * The vaddr this probe is installed will soon
> - * be vfreed buy not synced to disk. Hence,
> + * be vfreed but not synced to disk. Hence,
> * disarming the breakpoint isn't needed.
> *
> * Note, this will also move any optimized probes
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback
2020-10-08 3:05 ` Randy Dunlap
@ 2020-10-08 3:08 ` Zhouyi Zhou
0 siblings, 0 replies; 3+ messages in thread
From: Zhouyi Zhou @ 2020-10-08 3:08 UTC (permalink / raw)
To: Randy Dunlap
Cc: naveen.n.rao, anil.s.keshavamurthy, David Miller, mhiramat, linux-kernel
Thanks for the tip!
On Thu, Oct 8, 2020 at 11:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> > There is a tiny type error in comment of function kprobes_module_callback.
>
> Preferable
> typo
> and same in $Subject.
>
> 'type' usually means data type or maybe typedef, or even
> font or typeface.
>
> I suppose you could say a "typing" error (as in using a typewriter
> or keyboard).
>
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > ---
> > kernel/kprobes.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index e995541..9d2042b 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> > within_module_core((unsigned long)p->addr, mod))) {
> > /*
> > * The vaddr this probe is installed will soon
> > - * be vfreed buy not synced to disk. Hence,
> > + * be vfreed but not synced to disk. Hence,
> > * disarming the breakpoint isn't needed.
> > *
> > * Note, this will also move any optimized probes
> >
>
> thanks.
> --
> ~Randy
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-08 3:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 2:59 [PATCH] kprobes: Correct a type error in function kprobes_module_callback Zhouyi Zhou
2020-10-08 3:05 ` Randy Dunlap
2020-10-08 3:08 ` Zhouyi Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®